Java: Check compilation unit of the same element in both disjuncts.

aschackmull · aschackmull · commit d0de0254e1eb · 2019-05-20T16:41:08.000+02:00
diff --git a/java/ql/src/semmle/code/java/Annotation.qll b/java/ql/src/semmle/code/java/Annotation.qll
@@ -25,11 +25,11 @@ class Annotation extends @annotation, Expr {
 
   /** Gets the element being annotated. */
   Element getAnnotatedElement() {
-    this.getParent().(Field).getDeclaration().getAField() = result and
-    this.getCompilationUnit().fromSource()
-    or
-    not result.(Field).getCompilationUnit().fromSource() and
-    this.getParent() = result
+    exists(Element e | e = this.getParent() |
+      if e.(Field).getCompilationUnit().fromSource()
+      then result = e.(Field).getDeclaration().getAField()
+      else result = e
+    )
   }
 
   /** Gets the annotation type declaration for this annotation. */
