C#: Address review comments

calumgrant · calumgrant · commit d2aea635e4f4 · 2019-05-24T13:49:05.000+01:00
diff --git a/change-notes/1.21/analysis-csharp.md b/change-notes/1.21/analysis-csharp.md
@@ -17,7 +17,7 @@
 
 * The class `Attribute` has two new predicates: `getConstructorArgument()` and `getNamedArgument()`. The first predicate returns arguments to the underlying constructor call and the latter returns named arguments for initializing fields and properties.
 * The following QL classes have been added to model C# 8 features:
-    - Class `IndexExpr` models from end index expressions, for example `^1`
+    - Class `IndexExpr` models from-end index expressions, for example `^1`
     - Class `PatternExpr` is an `Expr` that appears in a pattern. It has the new subclasses `DiscardPatternExpr`, `LabeledPatternExpr`, `RecursivePatternExpr`, `TypeAccessPatternExpr`, `TypePatternExpr`, and `VariablePatternExpr`.
     - Class `PatternMatch` models a pattern being matched. It has the subclasses `Case` and `IsExpr`.
     - Class `PositionalPatternExpr` models position patterns, for example `(int x, int y)`
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/RangeExpression.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/RangeExpression.cs
@@ -14,7 +14,7 @@ protected override void Populate()
             if (!(Syntax.LeftOperand is null))
                 Expression.Create(cx, Syntax.LeftOperand, this, 0);
             if (!(Syntax.RightOperand is null))
-            Expression.Create(cx, Syntax.RightOperand, this, 1);
+                Expression.Create(cx, Syntax.RightOperand, this, 1);
         }
 
         public static Expression Create(ExpressionNodeInfo info) => new RangeExpression(info).TryPopulate();

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ protected override void Populate()`
`14`	`14`	`if (!(Syntax.LeftOperand is null))`
`15`	`15`	`Expression.Create(cx, Syntax.LeftOperand, this, 0);`
`16`	`16`	`if (!(Syntax.RightOperand is null))`
`17`		`- Expression.Create(cx, Syntax.RightOperand, this, 1);`
	`17`	`+ Expression.Create(cx, Syntax.RightOperand, this, 1);`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`public static Expression Create(ExpressionNodeInfo info) => new RangeExpression(info).TryPopulate();`