Merge pull request #3108 from aschackmull/java/finalizemethod

yo-h · web-flow · commit d315864383ab · 2020-03-23T18:27:57.000-04:00
Java: Fixup FinalizeMethod definition.
diff --git a/java/ql/src/semmle/code/java/Member.qll b/java/ql/src/semmle/code/java/Member.qll
@@ -481,13 +481,13 @@ class GetterMethod extends Method {
 
 /**
  * A finalizer method, with name `finalize`,
- * return type `void` and modifier `protected`.
+ * return type `void` and no parameters.
  */
 class FinalizeMethod extends Method {
   FinalizeMethod() {
     this.hasName("finalize") and
     this.getReturnType().hasName("void") and
-    this.isProtected()
+    this.hasNoParameters()
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -481,13 +481,13 @@ class GetterMethod extends Method {`
`481`	`481`
`482`	`482`	`/**`
`483`	`483`	* A finalizer method, with name `finalize`,
`484`		- * return type `void` and modifier `protected`.
	`484`	+ * return type `void` and no parameters.
`485`	`485`	`*/`
`486`	`486`	`class FinalizeMethod extends Method {`
`487`	`487`	`FinalizeMethod() {`
`488`	`488`	`this.hasName("finalize") and`
`489`	`489`	`this.getReturnType().hasName("void") and`
`490`		`- this.isProtected()`
	`490`	`+ this.hasNoParameters()`
`491`	`491`	`}`
`492`	`492`	`}`
`493`	`493`