C#: Re-factor nested exists into a single exists.

michaelnebel · michaelnebel · commit d3530b00834a · 2022-09-29T11:35:35.000+02:00
diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll
@@ -423,13 +423,11 @@ module LocalFlow {
   ControlFlow::Nodes::ExprNode getAPostUpdateNodeForArg(ControlFlow::Nodes::ExprNode arg) {
     arg.getExpr() instanceof Argument and
     result = getALastEvalNode*(arg) and
-    exists(Expr e | result.getExpr() = e |
-      exists(Type t | t = e.stripCasts().getType() |
-        t instanceof RefType and
-        not t instanceof NullType
-        or
-        t = any(TypeParameter tp | not tp.isValueType())
-      )
+    exists(Expr e, Type t | result.getExpr() = e and t = e.stripCasts().getType() |
+      t instanceof RefType and
+      not t instanceof NullType
+      or
+      t = any(TypeParameter tp | not tp.isValueType())
     ) and
     not exists(getALastEvalNode(result))
   }
