JS: Accept other changes to UnusedVariable

asgerf · asgerf · commit d3de6d18a44f · 2025-02-28T13:28:07.000+01:00
diff --git a/javascript/ql/test/query-tests/Declarations/UnusedVariable/UnusedIndexVariable.js b/javascript/ql/test/query-tests/Declarations/UnusedVariable/UnusedIndexVariable.js
@@ -1,6 +1,6 @@
 function sum(xs, i) {
   var res = 0;
-  for(;i++<xs.length;) // $ Alert - but flagged by js/unused-index-variable
+  for(;i++<xs.length;) // OK - flagged by js/unused-index-variable
     res += xs[0];
   return res;
 }
diff --git a/javascript/ql/test/query-tests/Declarations/UnusedVariable/eval.js b/javascript/ql/test/query-tests/Declarations/UnusedVariable/eval.js
@@ -7,7 +7,7 @@
     var used_by_eval = f();
 });
 (function(){
-    var not_used_by_eval = f();
+    var not_used_by_eval = f(); // $ Alert
     (function(){
         eval(src);
     })
@@ -16,5 +16,5 @@
     (function(){
         eval(src);
     })
-    var not_used_by_eval = f();
+    var not_used_by_eval = f(); // $ Alert
 });
diff --git a/javascript/ql/test/query-tests/Declarations/UnusedVariable/multi-imports.js b/javascript/ql/test/query-tests/Declarations/UnusedVariable/multi-imports.js
@@ -1,4 +1,4 @@
-import {a, b, c, d} from 'x';
-import {ordered, alphabetically} from 'x';
+import {a, b, c, d} from 'x'; // $ Alert
+import {ordered, alphabetically} from 'x'; // $ Alert
 
 c();

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`function sum(xs, i) {`
`2`	`2`	`var res = 0;`
`3`		`- for(;i++<xs.length;) // $ Alert - but flagged by js/unused-index-variable`
	`3`	`+ for(;i++<xs.length;) // OK - flagged by js/unused-index-variable`
`4`	`4`	`res += xs[0];`
`5`	`5`	`return res;`
`6`	`6`	`}`