JS: Autoformat and add qldoc

asgerf · asgerf · commit d52ff3e4f69e · 2021-03-17T13:29:16.000Z
diff --git a/javascript/ql/src/semmle/javascript/dataflow/TaintTracking.qll b/javascript/ql/src/semmle/javascript/dataflow/TaintTracking.qll
@@ -312,9 +312,8 @@ module TaintTracking {
    */
   cached
   private module Cached {
-    cached predicate forceStage() {
-      Stages::Taint::ref()
-    }
+    cached
+    predicate forceStage() { Stages::Taint::ref() }
 
     /**
      * Holds if `pred` &rarr; `succ` should be considered a taint-propagating
@@ -963,7 +962,8 @@ module TaintTracking {
         getACaptureSetter(pred) = getANodeReachingCaptureRef(succ)
         or
         exists(StringReplaceCall replace |
-          getANodeReachingCaptureRef(succ) = replace.getReplacementCallback().getFunction().getEntry() and
+          getANodeReachingCaptureRef(succ) =
+            replace.getReplacementCallback().getFunction().getEntry() and
           pred = replace.getReceiver()
         )
       }
diff --git a/javascript/ql/src/semmle/javascript/dataflow/internal/Unit.qll b/javascript/ql/src/semmle/javascript/dataflow/internal/Unit.qll
@@ -4,5 +4,6 @@ private newtype TUnit = MkUnit()
  * A class with only one instance.
  */
 class Unit extends TUnit {
+  /** Gets a textual representation of this element. */
   final string toString() { result = "Unit" }
 }
diff --git a/javascript/ql/src/semmle/javascript/frameworks/Angular2.qll b/javascript/ql/src/semmle/javascript/frameworks/Angular2.qll
@@ -590,7 +590,9 @@ module Angular2 {
   private class MatTableDataSourceStep extends TaintTracking::SharedTaintStep {
     override predicate step(DataFlow::Node pred, DataFlow::Node succ) {
       exists(DataFlow::NewNode invoke |
-        invoke = DataFlow::moduleMember("@angular/material/table", "MatTableDataSource").getAnInstantiation() and
+        invoke =
+          DataFlow::moduleMember("@angular/material/table", "MatTableDataSource")
+              .getAnInstantiation() and
         pred = [invoke.getArgument(0), invoke.getAPropertyWrite("data").getRhs()] and
         succ = invoke
       )
diff --git a/javascript/ql/src/semmle/javascript/frameworks/Classnames.qll b/javascript/ql/src/semmle/javascript/frameworks/Classnames.qll
@@ -24,7 +24,11 @@ private class PlainStep extends TaintTracking::SharedTaintStep {
 private class BindStep extends TaintTracking::SharedTaintStep {
   override predicate step(DataFlow::Node pred, DataFlow::Node succ) {
     exists(DataFlow::CallNode bind | bind = classnames().getAMemberCall("bind") |
-      pred = [succ.(DataFlow::CallNode).getAnArgument(), bind.getAnArgument(), bind.getOptionArgument(_, _)] and
+      pred =
+        [
+          succ.(DataFlow::CallNode).getAnArgument(), bind.getAnArgument(),
+          bind.getOptionArgument(_, _)
+        ] and
       succ = bind.getACall()
     )
   }
diff --git a/javascript/ql/src/semmle/javascript/frameworks/ComposedFunctions.qll b/javascript/ql/src/semmle/javascript/frameworks/ComposedFunctions.qll
@@ -112,7 +112,10 @@ module FunctionCompositionCall {
 
 private class ComposedFunctionTaintStep extends TaintTracking::SharedTaintStep {
   override predicate step(DataFlow::Node pred, DataFlow::Node succ) {
-    exists(int fnIndex, DataFlow::FunctionNode fn, FunctionCompositionCall composed, DataFlow::CallNode call |
+    exists(
+      int fnIndex, DataFlow::FunctionNode fn, FunctionCompositionCall composed,
+      DataFlow::CallNode call
+    |
       fn = composed.getOperandFunction(fnIndex) and
       call = composed.getACall()
     |
diff --git a/javascript/ql/src/semmle/javascript/frameworks/Vue.qll b/javascript/ql/src/semmle/javascript/frameworks/Vue.qll
@@ -307,7 +307,12 @@ module Vue {
     private DataFlow::PropWrite getAPropertyValueWrite(string name) {
       result = getData().getALocalSource().getAPropertyWrite(name)
       or
-      result = getABoundFunction().getALocalSource().(DataFlow::FunctionNode).getReceiver().getAPropertyWrite(name)
+      result =
+        getABoundFunction()
+            .getALocalSource()
+            .(DataFlow::FunctionNode)
+            .getReceiver()
+            .getAPropertyWrite(name)
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,6 @@ private newtype TUnit = MkUnit()`
`4`	`4`	`* A class with only one instance.`
`5`	`5`	`*/`
`6`	`6`	`class Unit extends TUnit {`
	`7`	`+ /** Gets a textual representation of this element. */`
`7`	`8`	`final string toString() { result = "Unit" }`
`8`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,11 @@ private class PlainStep extends TaintTracking::SharedTaintStep {`
`24`	`24`	`private class BindStep extends TaintTracking::SharedTaintStep {`
`25`	`25`	`override predicate step(DataFlow::Node pred, DataFlow::Node succ) {`
`26`	`26`	`exists(DataFlow::CallNode bind \| bind = classnames().getAMemberCall("bind") \|`
`27`		`- pred = [succ.(DataFlow::CallNode).getAnArgument(), bind.getAnArgument(), bind.getOptionArgument(_, _)] and`
	`27`	`+ pred =`
	`28`	`+ [`
	`29`	`+ succ.(DataFlow::CallNode).getAnArgument(), bind.getAnArgument(),`
	`30`	`+ bind.getOptionArgument(_, _)`
	`31`	`+ ] and`
`28`	`32`	`succ = bind.getACall()`
`29`	`33`	`)`
`30`	`34`	`}`