Fix mayHaveSideEffects for ReturnStmt

owen-mc · owen-mc · commit d588ee375b8e · 2022-12-06T15:07:45.000Z
The previous code only worked when the return statement
only has one returned expression.
diff --git a/go/ql/lib/semmle/go/Stmt.qll b/go/ql/lib/semmle/go/Stmt.qll
@@ -569,7 +569,7 @@ class ReturnStmt extends @returnstmt, Stmt {
   /** Gets the unique returned expression, if there is only one. */
   Expr getExpr() { getNumChild() = 1 and result = getExpr(0) }
 
-  override predicate mayHaveSideEffects() { getExpr().mayHaveSideEffects() }
+  override predicate mayHaveSideEffects() { getAnExpr().mayHaveSideEffects() }
 
   override string toString() { result = "return statement" }
 
