Quieten errors relating to generic type aliases

smowton · igfoo · commit d593185a8cb5 · 2022-05-10T19:51:17.000+01:00
Turns out type aliases are always substituted by the compiler, with the `IrSimpleType.abbreviation` field indicating what the original alias was if any. Therefore we're already extracting the right types. This commit simply omits extracting a kt_type for a type alias that uses type parameters as this certainly won't work at present because we don't have IrTypes for the type parameters declared by the alias and used in its RHS.
diff --git a/java/kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt b/java/kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt
@@ -724,7 +724,8 @@ open class KotlinFileExtractor(
         with("type alias", ta) {
             if (ta.typeParameters.isNotEmpty()) {
                 // TODO: Extract this information
-                logger.error("Type alias type parameters ignored for " + ta.render())
+                logger.error("Type alias with type parameters discarded: " + ta.render())
+                return
             }
             val id = useTypeAlias(ta)
             val locId = tw.getLocation(ta)
diff --git a/java/ql/test/kotlin/library-tests/type_aliases/aliases_with_type_parameters.kt b/java/ql/test/kotlin/library-tests/type_aliases/aliases_with_type_parameters.kt
@@ -0,0 +1,7 @@
+class Test<T> {}
+
+typealias Alias2<R> = Test<R>
+
+typealias Alias1<S> = Alias2<S>
+
+fun f() : Alias1<String> = Test<String>()
