JS: InconsistentNew regression test

asger-semmle · asger-semmle · commit dbfd0ae03b18 · 2019-10-09T12:16:11.000+01:00
diff --git a/javascript/ql/test/query-tests/LanguageFeatures/InconsistentNew/InconsistentNew.expected b/javascript/ql/test/query-tests/LanguageFeatures/InconsistentNew/InconsistentNew.expected
@@ -1,2 +1,3 @@
+| arraydef.js:1:1:1:19 | function Array() {} | Function Array is sometimes invoked as a constructor (for example $@), and sometimes as a normal function (for example $@). | arraycalls.js:2:1:2:13 | new Array(45) | here | arraycalls.js:1:1:1:9 | Array(45) | here |
 | m.js:1:8:1:22 | functio ...  = x;\\n} | Function A is sometimes invoked as a constructor (for example $@), and sometimes as a normal function (for example $@). | c1.js:2:1:2:9 | new A(42) | here | c2.js:2:1:2:5 | A(23) | here |
 | tst.js:1:1:1:22 | functio ...  = y;\\n} | Function Point is sometimes invoked as a constructor (for example $@), and sometimes as a normal function (for example $@). | tst.js:6:1:6:17 | new Point(23, 42) | here | tst.js:7:1:7:13 | Point(56, 72) | here |
diff --git a/javascript/ql/test/query-tests/LanguageFeatures/InconsistentNew/arraycalls.js b/javascript/ql/test/query-tests/LanguageFeatures/InconsistentNew/arraycalls.js
@@ -0,0 +1,2 @@
+Array(45); // OK
+new Array(45); // OK
diff --git a/javascript/ql/test/query-tests/LanguageFeatures/InconsistentNew/arraydef.js b/javascript/ql/test/query-tests/LanguageFeatures/InconsistentNew/arraydef.js
@@ -0,0 +1,2 @@
+function Array() {}
+Array.prototype.foo = function() {};
diff --git a/javascript/ql/test/query-tests/LanguageFeatures/InconsistentNew/externs.js b/javascript/ql/test/query-tests/LanguageFeatures/InconsistentNew/externs.js
@@ -1,4 +1,10 @@
 function Error() {}
+Error.prototype.toString = function() {};
+
 function String() {}
+String.prototype.toString = function() {};
+
+function Array() {}
+Array.prototype.toString = function() {};
 
 //semmle-extractor-options: --externs

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
	`1`	`+\| arraydef.js:1:1:1:19 \| function Array() {} \| Function Array is sometimes invoked as a constructor (for example $@), and sometimes as a normal function (for example $@). \| arraycalls.js:2:1:2:13 \| new Array(45) \| here \| arraycalls.js:1:1:1:9 \| Array(45) \| here \|`
`1`	`2`	`\| m.js:1:8:1:22 \| functio ... = x;\\n} \| Function A is sometimes invoked as a constructor (for example $@), and sometimes as a normal function (for example $@). \| c1.js:2:1:2:9 \| new A(42) \| here \| c2.js:2:1:2:5 \| A(23) \| here \|`
`2`	`3`	`\| tst.js:1:1:1:22 \| functio ... = y;\\n} \| Function Point is sometimes invoked as a constructor (for example $@), and sometimes as a normal function (for example $@). \| tst.js:6:1:6:17 \| new Point(23, 42) \| here \| tst.js:7:1:7:13 \| Point(56, 72) \| here \|`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Array(45); // OK`
	`2`	`+new Array(45); // OK`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+function Array() {}`
	`2`	`+Array.prototype.foo = function() {};`