Add flowCheckNodeSpecific

owen-mc · owen-mc · commit dd57d9fd550d · 2023-06-14T14:27:58.000+01:00
This allows individual languages to specify `FlowCheckNode`s, which
break up the big step relation and make sure that those nodes appear in
path summaries.
diff --git a/go/ql/lib/semmle/go/dataflow/internal/DataFlowImpl.qll b/go/ql/lib/semmle/go/dataflow/internal/DataFlowImpl.qll
@@ -2021,7 +2021,8 @@ module Impl<FullStateConfigSig Config> {
       FlowCheckNode() {
         castNode(this.asNode()) or
         clearsContentCached(this.asNode(), _) or
-        expectsContentCached(this.asNode(), _)
+        expectsContentCached(this.asNode(), _) or
+        flowCheckNodeSpecific(this.asNode())
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -2021,7 +2021,8 @@ module Impl<FullStateConfigSig Config> {`
`2021`	`2021`	`FlowCheckNode() {`
`2022`	`2022`	`castNode(this.asNode()) or`
`2023`	`2023`	`clearsContentCached(this.asNode(), _) or`
`2024`		`- expectsContentCached(this.asNode(), _)`
	`2024`	`+ expectsContentCached(this.asNode(), _) or`
	`2025`	`+ flowCheckNodeSpecific(this.asNode())`
`2025`	`2026`	`}`
`2026`	`2027`	`}`
`2027`	`2028`