Improved SpringHttpInvokerUnsafeDeserialization.qhelp

artem-smotrakov · artem-smotrakov · commit e02b51f42bad · 2021-02-24T22:35:20.000+01:00
diff --git a/java/ql/src/experimental/Security/CWE/CWE-502/SpringHttpInvokerUnsafeDeserialization.qhelp b/java/ql/src/experimental/Security/CWE/CWE-502/SpringHttpInvokerUnsafeDeserialization.qhelp
@@ -21,14 +21,17 @@ Spring Framework also provides two classes that extend <code>RemoteInvocationSer
 <p>
 These classes export specified beans as HTTP endpoints that deserialize data from an HTTP request
 using unsafe <code>ObjectInputStream</code>. If a remote attacker can reach such endpoints,
-it results in remote code execution.
+it results in remote code execution in the worst case.
+</p>
+<p>
+CVE-2016-1000027 has been assigned to this issue in Spring Framework. There is no fix for that.
 </p>
 </overview>
 
 <recommendation>
 <p>
 Avoid using <code>HttpInvokerServiceExporter</code>, <code>SimpleHttpInvokerServiceExporter</code>
-and other exporters that are based on <code>RemoteInvocationSerializingExporter</code>.
+and any other exporter that is based on <code>RemoteInvocationSerializingExporter</code>.
 Instead, use other message formats for API endpoints (for example, JSON),
 but make sure that the underlying deserialization mechanism is properly configured
 so that deserialization attacks are not possible. If the vulnerable exporters can not be replaced,
@@ -50,6 +53,14 @@ OWASP:
 <a href="https://www.owasp.org/index.php/Deserialization_of_untrusted_data">Deserialization of untrusted data</a>.
 </li>
 <li>
+Spring Framework API documentation:
+<a href="https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/remoting/rmi/RemoteInvocationSerializingExporter.html">RemoteInvocationSerializingExporter class</a>
+</li>
+<li>
+Spring Framework API documentation:
+<a href="https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/remoting/httpinvoker/HttpInvokerServiceExporter.html">HttpInvokerServiceExporter class</a>
+</li>
+<li>
 National Vulnerability Database:
 <a href="https://nvd.nist.gov/vuln/detail/CVE-2016-1000027">CVE-2016-1000027</a>
 </li>
@@ -66,4 +77,5 @@ OpenJDK:
 <a href="https://openjdk.java.net/jeps/290">JEP 290: Filter Incoming Serialization Data</a>
 </li>
 </references>
+
 </qhelp>
