Apply suggestions from code review

yoff · tausbn · web-flow · commit e072864948ba · 2021-01-20T17:38:34.000+01:00
Co-authored-by: Taus &lt;tausbn@github.com&gt;
diff --git a/python/ql/src/semmle/python/dataflow/new/internal/DataFlowPrivate.qll b/python/ql/src/semmle/python/dataflow/new/internal/DataFlowPrivate.qll
@@ -148,7 +148,7 @@ module EssaFlow {
       contextManager.strictlyDominates(var)
     )
     or
-    // Paramter definition
+    // Parameter definition
     //   `def foo(x):`
     //   nodeFrom is `x`, cfgNode
     //   nodeTo is `x`, essa var
diff --git a/python/ql/src/semmle/python/dataflow/new/internal/DataFlowPublic.qll b/python/ql/src/semmle/python/dataflow/new/internal/DataFlowPublic.qll
@@ -64,7 +64,7 @@ newtype TNode =
   /**
    * A synthetic node representing that an iterable sequence flows to consumer.
    */
-  TIterableSequence(UnpackingAssignmentTarget consumer) { consumer instanceof SequenceNode } or
+  TIterableSequence(UnpackingAssignmentSequenceTarget consumer) or
   /**
    * A synthetic node representing that there may be an iterable element
    * for `consumer` to consume.

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ module EssaFlow {`
`148`	`148`	`contextManager.strictlyDominates(var)`
`149`	`149`	`)`
`150`	`150`	`or`
`151`		`- // Paramter definition`
	`151`	`+ // Parameter definition`
`152`	`152`	// `def foo(x):`
`153`	`153`	// nodeFrom is `x`, cfgNode
`154`	`154`	// nodeTo is `x`, essa var