JavaScript: address comments

asger-semmle · asger-semmle · commit e39b0c7a75d8 · 2018-11-05T11:31:02.000Z
diff --git a/javascript/ql/src/Expressions/SelfAssignment.ql b/javascript/ql/src/Expressions/SelfAssignment.ql
@@ -44,6 +44,6 @@ where e.same(_) and
       ) and
       // exclude DOM properties
       not isDOMProperty(e.(PropAccess).getPropertyName()) and
-      // exclude self-assignments with a JSDoc comment
-      not exists(e.getAssignment().getParent().(ExprStmt).getDocumentation().getATag())
+      // exclude self-assignments that have been inserted to satisfy the TypeScript JS-checker
+      not e.getAssignment().getParent().(ExprStmt).getDocumentation().getATag().getTitle() = "type"
 select e.getParent(), "This expression assigns " + dsc + " to itself."
