C++: Test showing no flow through aggregate init

jbj · jbj · commit e419ea01407d · 2019-08-15T11:33:25.000+02:00
diff --git a/cpp/ql/test/library-tests/dataflow/fields/struct_init.c b/cpp/ql/test/library-tests/dataflow/fields/struct_init.c
@@ -0,0 +1,38 @@
+void sink(void *o);
+void *user_input(void);
+
+struct AB {
+  void *a;
+  void *b;
+};
+
+struct Outer {
+  struct AB nestedAB;
+  struct AB *pointerAB;
+};
+
+void absink(struct AB *ab) {
+  sink(ab->a); // flow x3 [NOT DETECTED]
+  sink(ab->b); // no flow
+}
+
+int struct_init(void) {
+  struct AB ab = { user_input(), 0 };
+
+  sink(ab.a); // flow [NOT DETECTED]
+  sink(ab.b); // no flow
+  absink(&ab);
+
+  struct Outer outer = {
+    { user_input(), 0 },
+    &ab,
+  };
+
+  sink(outer.nestedAB.a); // flow [NOT DETECTED]
+  sink(outer.nestedAB.b); // no flow
+  sink(outer.pointerAB->a); // flow [NOT DETECTED]
+  sink(outer.pointerAB->b); // no flow
+
+  absink(&outer.nestedAB);
+  absink(outer.pointerAB);
+}
