Merge pull request #2818 from BekaValentine/objectapi-to-valueapi-hashedbutnohash

tausbn · web-flow · commit e444fb8bfad1 · 2020-02-21T22:19:58.000+01:00
Python: ObjectAPI to ValueAPI: HashedButNoHash
diff --git a/python/ql/src/Expressions/HashedButNoHash.ql b/python/ql/src/Expressions/HashedButNoHash.ql
@@ -69,7 +69,7 @@ predicate is_unhashable(ControlFlowNode f, ClassValue cls, ControlFlowNode origi
 predicate typeerror_is_caught(ControlFlowNode f) {
     exists (Try try |
         try.getBody().contains(f.getNode()) and
-        try.getAHandler().getType().refersTo(theTypeErrorType()))
+        try.getAHandler().getType().pointsTo(ClassValue::typeError()))
 }
 
 from ControlFlowNode f, ClassValue c, ControlFlowNode origin

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ predicate is_unhashable(ControlFlowNode f, ClassValue cls, ControlFlowNode origi`
`69`	`69`	`predicate typeerror_is_caught(ControlFlowNode f) {`
`70`	`70`	`exists (Try try \|`
`71`	`71`	`try.getBody().contains(f.getNode()) and`
`72`		`- try.getAHandler().getType().refersTo(theTypeErrorType()))`
	`72`	`+ try.getAHandler().getType().pointsTo(ClassValue::typeError()))`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`from ControlFlowNode f, ClassValue c, ControlFlowNode origin`