JS: Accept a double-flagged line

asgerf · asgerf · commit e5bee19b1951 · 2025-02-28T13:27:51.000+01:00
This is flagged by two queries but for two separate issues. Seems valid to flag it twice.
diff --git a/javascript/ql/test/query-tests/Security/CWE-116/IncompleteSanitization/tst.js b/javascript/ql/test/query-tests/Security/CWE-116/IncompleteSanitization/tst.js
@@ -338,7 +338,7 @@ function typicalBadHtmlSanitizers(s) {
 }
 
 function bad18NewRegExp(p) {
-	return p.replace(new RegExp("\\.\\./"), "");
+	return p.replace(new RegExp("\\.\\./"), ""); // $ Alert[js/incomplete-sanitization] Alert[js/incomplete-multi-character-sanitization] -- both lacking global flag, and multi-char replacement problem
 }
 
 function bad4NewRegExpG(s) {

Original file line number	Diff line number	Diff line change
`@@ -338,7 +338,7 @@ function typicalBadHtmlSanitizers(s) {`
`338`	`338`	`}`
`339`	`339`
`340`	`340`	`function bad18NewRegExp(p) {`
`341`		`- return p.replace(new RegExp("\\.\\./"), "");`
	`341`	`+ return p.replace(new RegExp("\\.\\./"), ""); // $ Alert[js/incomplete-sanitization] Alert[js/incomplete-multi-character-sanitization] -- both lacking global flag, and multi-char replacement problem`
`342`	`342`	`}`
`343`	`343`
`344`	`344`	`function bad4NewRegExpG(s) {`