JS: implement getADataNode for NodeHttpUrlRequest

Esben Sparre Andreasen · Esben Sparre Andreasen · commit e7836d74ab3a · 2018-10-16T08:51:32.000+02:00
diff --git a/javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll b/javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll
@@ -740,7 +740,10 @@ module NodeJSLib {
     }
 
     override DataFlow::Node getADataNode() {
-      result = getAMethodCall("write").getArgument(0)
+      exists (string name |
+        name = "write" or name = "end" |
+        result =this.(DataFlow::SourceNode).getAMethodCall(name).getArgument(0)
+      )
     }
 
   }
diff --git a/javascript/ql/test/library-tests/frameworks/NodeJSLib/ClientRequest_getADataNode.expected b/javascript/ql/test/library-tests/frameworks/NodeJSLib/ClientRequest_getADataNode.expected
@@ -0,0 +1,2 @@
+| src/http.js:27:16:27:73 | http.re ... POST'}) | src/http.js:50:16:50:22 | 'stuff' |
+| src/http.js:27:16:27:73 | http.re ... POST'}) | src/http.js:51:14:51:25 | 'more stuff' |
diff --git a/javascript/ql/test/library-tests/frameworks/NodeJSLib/ClientRequest_getADataNode.ql b/javascript/ql/test/library-tests/frameworks/NodeJSLib/ClientRequest_getADataNode.ql
@@ -0,0 +1,4 @@
+import javascript
+
+from NodeJSLib::NodeJSClientRequest cr
+select cr, cr.getADataNode()

Original file line number	Diff line number	Diff line change
`@@ -740,7 +740,10 @@ module NodeJSLib {`
`740`	`740`	`}`
`741`	`741`
`742`	`742`	`override DataFlow::Node getADataNode() {`
`743`		`- result = getAMethodCall("write").getArgument(0)`
	`743`	`+ exists (string name \|`
	`744`	`+ name = "write" or name = "end" \|`
	`745`	`+ result =this.(DataFlow::SourceNode).getAMethodCall(name).getArgument(0)`
	`746`	`+ )`
`744`	`747`	`}`
`745`	`748`
`746`	`749`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+\| src/http.js:27:16:27:73 \| http.re ... POST'}) \| src/http.js:50:16:50:22 \| 'stuff' \|`
	`2`	`+\| src/http.js:27:16:27:73 \| http.re ... POST'}) \| src/http.js:51:14:51:25 \| 'more stuff' \|`