CPP: Add a test of UnusedStaticVariable.ql.

geoffw0 · geoffw0 · commit e7f19e97cb5f · 2018-12-05T10:01:54.000Z
diff --git a/cpp/ql/test/query-tests/Best Practices/Unused Entities/UnusedStaticVariables/UnusedStaticVariables.expected b/cpp/ql/test/query-tests/Best Practices/Unused Entities/UnusedStaticVariables/UnusedStaticVariables.expected
@@ -0,0 +1,3 @@
+| test.cpp:7:12:7:21 | staticVar5 | Static variable staticVar5 is never read |
+| test.cpp:8:12:8:21 | staticVar6 | Static variable staticVar6 is never read |
+| test.cpp:9:40:9:49 | staticVar7 | Static variable staticVar7 is never read |
diff --git a/cpp/ql/test/query-tests/Best Practices/Unused Entities/UnusedStaticVariables/UnusedStaticVariables.qlref b/cpp/ql/test/query-tests/Best Practices/Unused Entities/UnusedStaticVariables/UnusedStaticVariables.qlref
@@ -0,0 +1 @@
+Best Practices/Unused Entities/UnusedStaticVariables.ql
diff --git a/cpp/ql/test/query-tests/Best Practices/Unused Entities/UnusedStaticVariables/test.cpp b/cpp/ql/test/query-tests/Best Practices/Unused Entities/UnusedStaticVariables/test.cpp
@@ -0,0 +1,18 @@
+
+int globalVar; // GOOD (not static)
+static int staticVar1; // GOOD (used)
+static int staticVar2; // GOOD (used)
+static int staticVar3 = 3; // GOOD (used)
+static int staticVar4 = staticVar3; // GOOD (used)
+static int staticVar5; // BAD (unused)
+static int staticVar6 = 6; // BAD (unused)
+static __attribute__((__unused__)) int staticVar7; // GOOD (unused but this is expected) [FALSE POSITIVE]
+
+void f()
+{
+	int *ptr = &staticVar4;
+
+	staticVar1 = staticVar2;
+	(*ptr) = 0;
+}
+

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+\| test.cpp:7:12:7:21 \| staticVar5 \| Static variable staticVar5 is never read \|`
	`2`	`+\| test.cpp:8:12:8:21 \| staticVar6 \| Static variable staticVar6 is never read \|`
	`3`	`+\| test.cpp:9:40:9:49 \| staticVar7 \| Static variable staticVar7 is never read \|`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Best Practices/Unused Entities/UnusedStaticVariables.ql`