remove redundent imports

am0o0 · am0o0 · commit e87d2fe9224b · 2024-07-09T19:41:06.000+02:00
diff --git a/java/ql/src/experimental/semmle/code/java/security/DecompressionBomb.qll b/java/ql/src/experimental/semmle/code/java/security/DecompressionBomb.qll
@@ -2,14 +2,6 @@ import java
 private import semmle.code.java.dataflow.TaintTracking
 
 module DecompressionBomb {
-  newtype DecompressionState =
-    Zip4j() or
-    Inflator() or
-    ApacheCommons() or
-    XerialSnappy() or
-    UtilZip() or
-    ZipFile()
-
   /**
    * The Decompression bomb Sink
    *
diff --git a/java/ql/src/experimental/semmle/code/java/security/DecompressionBombQuery.qll b/java/ql/src/experimental/semmle/code/java/security/DecompressionBombQuery.qll
@@ -1,6 +1,4 @@
-import semmle.code.java.dataflow.FlowSources
 import experimental.semmle.code.java.security.FileAndFormRemoteSource
-import semmle.code.java.dataflow.TaintTracking
 import experimental.semmle.code.java.security.DecompressionBomb::DecompressionBomb
 
 module DecompressionBombsConfig implements DataFlow::ConfigSig {
diff --git a/java/ql/src/experimental/semmle/code/java/security/FileAndFormRemoteSource.qll b/java/ql/src/experimental/semmle/code/java/security/FileAndFormRemoteSource.qll
@@ -1,5 +1,4 @@
 import java
-import semmle.code.java.dataflow.DataFlow
 import semmle.code.java.dataflow.FlowSources
 
 class CommonsFileUploadAdditionalTaintStep extends Unit {
@@ -31,7 +30,7 @@ module ApacheCommonsFileUpload {
       ServletFileUpload() {
         exists(MethodAccess ma |
           ma.getReceiverType() instanceof TypeServletFileUpload and
-          ma.getCallee().hasName(["parseRequest"]) and
+          ma.getCallee().hasName("parseRequest") and
           this.asExpr() = ma
         )
       }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import java`
`2`		`-import semmle.code.java.dataflow.DataFlow`
`3`	`2`	`import semmle.code.java.dataflow.FlowSources`
`4`	`3`
`5`	`4`	`class CommonsFileUploadAdditionalTaintStep extends Unit {`
`@@ -31,7 +30,7 @@ module ApacheCommonsFileUpload {`
`31`	`30`	`ServletFileUpload() {`
`32`	`31`	`exists(MethodAccess ma \|`
`33`	`32`	`ma.getReceiverType() instanceof TypeServletFileUpload and`
`34`		`- ma.getCallee().hasName(["parseRequest"]) and`
	`33`	`+ ma.getCallee().hasName("parseRequest") and`
`35`	`34`	`this.asExpr() = ma`
`36`	`35`	`)`
`37`	`36`	`}`