Update javascript/ql/src/semmle/javascript/dataflow/internal/CallGraphs.qll

erik-krogh · asgerf · web-flow · commit ea6d3bde9c6e · 2021-03-10T15:00:48.000+01:00
Co-authored-by: Asger F &lt;asgerf@github.com&gt;
diff --git a/javascript/ql/src/semmle/javascript/dataflow/internal/CallGraphs.qll b/javascript/ql/src/semmle/javascript/dataflow/internal/CallGraphs.qll
@@ -59,7 +59,10 @@ module CallGraph {
 
   /**
    * Gets a reference to `function` type-tracked by `t`.
-   * Only considers callgraph specific steps.
+   *
+   * This only includes steps that aren't included in ordinary type-tracking.
+   * For example, this steps from a method definition to an access on an instance, but
+   * does not step through access paths, as those are included in type-tracking already.
    */
   cached
   DataFlow::SourceNode callgraphStep(DataFlow::FunctionNode function, DataFlow::TypeTracker t) {
