Python: Prevent potentially bad join order

tausbn · tausbn · commit ed8ffab35677 · 2021-03-24T19:20:19.000+01:00
This has no effect on the current compilation (indeed,
`ssa_filter_definition_bool` is not currently inlined), but will
prevent this from ever occurring, should the heuristics for inlining
ever change...
diff --git a/python/ql/src/semmle/python/pointsto/PointsTo.qll b/python/ql/src/semmle/python/pointsto/PointsTo.qll
@@ -524,6 +524,7 @@ module PointsToInternal {
     )
   }
 
+  pragma[noinline]
   private boolean ssa_filter_definition_bool(
     PyEdgeRefinement def, PointsToContext context, ObjectInternal value, ControlFlowNode origin
   ) {

Original file line number	Diff line number	Diff line change
`@@ -524,6 +524,7 @@ module PointsToInternal {`
`524`	`524`	`)`
`525`	`525`	`}`
`526`	`526`
	`527`	`+ pragma[noinline]`
`527`	`528`	`private boolean ssa_filter_definition_bool(`
`528`	`529`	`PyEdgeRefinement def, PointsToContext context, ObjectInternal value, ControlFlowNode origin`
`529`	`530`	`) {`