C++: Deprecate class Qualifier

jbj · jbj · commit edc9e23a9db6 · 2019-10-24T15:22:44.000+02:00
It's not used anywhere outside `VoidContext.qll`, where it was defined.
The use in `VoidContext.qll` is 10 years old and was a workaround for an
extractor bug that no longer exists.
diff --git a/cpp/ql/src/semmle/code/cpp/commons/VoidContext.qll b/cpp/ql/src/semmle/code/cpp/commons/VoidContext.qll
@@ -1,9 +1,10 @@
 import semmle.code.cpp.exprs.Expr
 
 /**
+ * DEPRECATED: This class has not been useful.
  * An expression that is used to qualify some other expression.
  */
-class Qualifier extends Expr {
+deprecated class Qualifier extends Expr {
   Qualifier() {
     exists(VariableAccess a | a.getQualifier() = this) or
     exists(Call c | c.getQualifier() = this) or
@@ -36,6 +37,5 @@ private predicate exprInVoidContext(Expr e) {
     or
     exists(CommaExpr c | c.getRightOperand() = e and c instanceof ExprInVoidContext)
   ) and
-  not e instanceof Qualifier and
   not e.getActualType() instanceof VoidType
 }
