C++: Remove an unnecessary predicate from the 'Indirection' class.

MathiasVP · MathiasVP · commit ef110e77ff35 · 2022-12-15T11:54:32.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternalsCommon.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternalsCommon.qll
@@ -176,12 +176,6 @@ abstract class Indirection extends Type {
    * from `opFrom` to `instrTo`.
    */
   predicate isAdditionalConversionFlow(Operand opFrom, Instruction instrTo) { none() }
-
-  /**
-   * Holds if writing the value `value` to an address with base `base` should
-   * be ignored.
-   */
-  predicate ignoreSourceVariableBase(BaseSourceVariableInstruction base, Node0Impl value) { none() }
 }
 
 private class PointerOrReferenceTypeIndirection extends Indirection instanceof PointerOrReferenceType {
@@ -231,10 +225,6 @@ predicate isAdditionalConversionFlow(Operand opFrom, Instruction instrTo) {
   any(Indirection ind).isAdditionalConversionFlow(opFrom, instrTo)
 }
 
-predicate ignoreSourceVariableBase(BaseSourceVariableInstruction base, Node0Impl value) {
-  any(Indirection ind).ignoreSourceVariableBase(base, value)
-}
-
 newtype TBaseSourceVariable =
   // Each IR variable gets its own source variable
   TBaseIRVariable(IRVariable var) or
