C++: Add comment for false positives in swap tests

Robert Marsh · Robert Marsh · commit ef940e815f74 · 2020-06-16T11:46:14.000-07:00
diff --git a/cpp/ql/test/library-tests/dataflow/taint-tests/swap1.cpp b/cpp/ql/test/library-tests/dataflow/taint-tests/swap1.cpp
@@ -71,7 +71,7 @@ void test_copy_assignment_operator()
 
     swap(z1, z2);
 
-    sink(z2.data1); // tainted
+    sink(z2.data1); // tainted [FALSE NEGATIVE in IR]
     sink(z1.data1); // clean [FALSE POSITIVE]
 }
 
diff --git a/cpp/ql/test/library-tests/dataflow/taint-tests/swap2.cpp b/cpp/ql/test/library-tests/dataflow/taint-tests/swap2.cpp
@@ -71,7 +71,7 @@ void test_copy_assignment_operator()
 
     swap(z1, z2);
 
-    sink(z2.data1); // tainted
+    sink(z2.data1); // tainted [FALSE NEGATIVE in IR]
     sink(z1.data1); // clean [FALSE POSITIVE]
 }
 

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ void test_copy_assignment_operator()`
`71`	`71`
`72`	`72`	`swap(z1, z2);`
`73`	`73`
`74`		`- sink(z2.data1); // tainted`
	`74`	`+ sink(z2.data1); // tainted [FALSE NEGATIVE in IR]`
`75`	`75`	`sink(z1.data1); // clean [FALSE POSITIVE]`
`76`	`76`	`}`
`77`	`77`