Add dataflow test for property reference being used as lambda

tamasvajk · igfoo · commit f12bcc571559 · 2022-05-10T19:51:25.000+01:00
diff --git a/java/ql/test/kotlin/library-tests/dataflow/func/functionReference.kt b/java/ql/test/kotlin/library-tests/dataflow/func/functionReference.kt
@@ -10,5 +10,10 @@ class FunctionReference {
         Helper.sink(Processor().process(this::fn1, Helper.notaint()))
         Helper.sink(Processor().process(::fn2, Helper.taint()))
         Helper.sink(Processor().process(::fn2, Helper.notaint()))
+
+        Helper.sink(Processor().process(this::prop))
     }
+
+    val prop: String
+        get() = Helper.taint()
 }
diff --git a/java/ql/test/kotlin/library-tests/dataflow/func/test.expected b/java/ql/test/kotlin/library-tests/dataflow/func/test.expected
@@ -1,6 +1,7 @@
 | functionReference.kt:8:59:8:65 | taint(...) | functionReference.kt:8:33:8:66 | process(...) |
 | functionReference.kt:9:78:9:84 | taint(...) | functionReference.kt:9:33:9:85 | process(...) |
 | functionReference.kt:11:55:11:61 | taint(...) | functionReference.kt:11:33:11:62 | process(...) |
+| functionReference.kt:18:24:18:30 | taint(...) | functionReference.kt:14:33:14:51 | process(...) |
 | lambda.kt:4:64:4:70 | taint(...) | lambda.kt:4:33:4:77 | process(...) |
 | lambda.kt:5:60:5:66 | taint(...) | lambda.kt:5:33:5:67 | process(...) |
 | lambda.kt:6:69:6:75 | taint(...) | lambda.kt:6:33:6:76 | process(...) |
diff --git a/java/ql/test/kotlin/library-tests/dataflow/func/util.kt b/java/ql/test/kotlin/library-tests/dataflow/func/util.kt
@@ -1,4 +1,8 @@
 class Processor {
+    fun <R> process(f: () -> R) : R {
+        return f()
+    }
+
     fun <T, R> process(f: (T) -> R, arg: T) : R {
         return f(arg)
     }

Original file line number	Diff line number	Diff line change
`@@ -10,5 +10,10 @@ class FunctionReference {`
`10`	`10`	`Helper.sink(Processor().process(this::fn1, Helper.notaint()))`
`11`	`11`	`Helper.sink(Processor().process(::fn2, Helper.taint()))`
`12`	`12`	`Helper.sink(Processor().process(::fn2, Helper.notaint()))`
	`13`	`+`
	`14`	`+ Helper.sink(Processor().process(this::prop))`
`13`	`15`	`}`
	`16`	`+`
	`17`	`+ val prop: String`
	`18`	`+ get() = Helper.taint()`
`14`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,8 @@`
`1`	`1`	`class Processor {`
	`2`	`+ fun <R> process(f: () -> R) : R {`
	`3`	`+ return f()`
	`4`	`+ }`
	`5`	`+`
`2`	`6`	`fun <T, R> process(f: (T) -> R, arg: T) : R {`
`3`	`7`	`return f(arg)`
`4`	`8`	`}`