C#/Kotlin: Sync SignAnalysisCommon.qll

igfoo · igfoo · commit f138ba5246f8 · 2022-05-10T19:51:24.000+01:00
diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/SignAnalysisCommon.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/SignAnalysisCommon.qll
@@ -49,7 +49,7 @@ private predicate unknownSign(Expr e) {
     or
     exists(LongLiteral lit | lit = e and not exists(lit.getValue().toFloat()))
     or
-    exists(CastExpr cast, Type fromtyp |
+    exists(CastingExpr cast, Type fromtyp |
       cast = e and
       fromtyp = cast.getSourceType() and
       not fromtyp instanceof NumericOrCharType
diff --git a/csharp/ql/lib/semmle/code/csharp/exprs/Expr.qll b/csharp/ql/lib/semmle/code/csharp/exprs/Expr.qll
@@ -710,6 +710,14 @@ class AsExpr extends Cast, @as_expr {
   override string getAPrimaryQlClass() { result = "AsExpr" }
 }
 
+/**
+ * Any kind of expression that casts values from one type to another.
+ *
+ * For C#, this is only `CastExpr`.
+ */
+class CastingExpr extends CastExpr {
+}
+
 /**
  * A cast expression, for example `(string) x`.
  */
diff --git a/java/ql/lib/semmle/code/java/Expr.qll b/java/ql/lib/semmle/code/java/Expr.qll
@@ -1207,6 +1207,12 @@ class LogNotExpr extends UnaryExpr, @lognotexpr {
   override string getAPrimaryQlClass() { result = "LogNotExpr" }
 }
 
+/**
+ * Any kind of expression that casts values from one type to another.
+ *
+ * For Java, this is only `CastExpr`, but for Kotlin it includes
+ * various other explicit or implicit casting operators.
+ */
 class CastingExpr extends Expr {
   CastingExpr() {
     this instanceof @castexpr or
