Update class/method names in the module

luchua-bc · luchua-bc · commit f13b8814f5d0 · 2021-01-06T16:49:35.000Z
diff --git a/java/ql/src/experimental/Security/CWE/CWE-312/CleartextStorageSharedPrefs.ql b/java/ql/src/experimental/Security/CWE/CWE-312/CleartextStorageSharedPrefs.ql
@@ -83,11 +83,11 @@ private class EncryptedSharedPrefFlowConfig extends DataFlow4::Configuration {
   }
 
   override predicate isSource(DataFlow4::Node src) {
-    src.asExpr().(MethodAccess).getMethod() instanceof SharedPreferences::CreateEncryptedPrefsMethod
+    src.asExpr().(MethodAccess).getMethod() instanceof SharedPreferences::CreateEncryptedMethod
   }
 
   override predicate isSink(DataFlow4::Node sink) {
-    sink.asExpr().getType() instanceof SharedPreferences::TypePrefs
+    sink.asExpr().getType() instanceof SharedPreferences::TypeBase
   }
 }
 
diff --git a/java/ql/src/semmle/code/java/frameworks/android/SharedPreferences.qll b/java/ql/src/semmle/code/java/frameworks/android/SharedPreferences.qll
@@ -5,37 +5,35 @@ import java
 /** Definitions related to `android.content.SharedPreferences`. */
 module SharedPreferences {
   /** The interface `android.content.SharedPreferences` */
-  class TypePrefs extends Interface {
-    TypePrefs() { hasQualifiedName("android.content", "SharedPreferences") }
+  class TypeBase extends Interface {
+    TypeBase() { hasQualifiedName("android.content", "SharedPreferences") }
   }
 
   /** The class `androidx.security.crypto.EncryptedSharedPreferences`, which implements `SharedPreferences` with encryption support. */
-  class TypeEncryptedPrefs extends Class {
-    TypeEncryptedPrefs() {
-      hasQualifiedName("androidx.security.crypto", "EncryptedSharedPreferences")
-    }
+  class TypeEncrypted extends Class {
+    TypeEncrypted() { hasQualifiedName("androidx.security.crypto", "EncryptedSharedPreferences") }
   }
 
   /** The create method of `androidx.security.crypto.EncryptedSharedPreferences` */
-  class CreateEncryptedPrefsMethod extends Method {
-    CreateEncryptedPrefsMethod() {
-      getDeclaringType() instanceof TypeEncryptedPrefs and
+  class CreateEncryptedMethod extends Method {
+    CreateEncryptedMethod() {
+      getDeclaringType() instanceof TypeEncrypted and
       hasName("create")
     }
   }
 
   /** A getter method of `android.content.SharedPreferences`. */
   class GetPreferenceMethod extends Method {
     GetPreferenceMethod() {
-      getDeclaringType() instanceof TypePrefs and
+      getDeclaringType() instanceof TypeBase and
       getName().matches("get%")
     }
   }
 
   /** Returns `android.content.SharedPreferences.Editor` from the `edit` call of `android.content.SharedPreferences`. */
   class GetEditorMethod extends Method {
     GetEditorMethod() {
-      getDeclaringType() instanceof TypePrefs and
+      getDeclaringType() instanceof TypeBase and
       hasName("edit") and
       getReturnType() instanceof TypeEditor
     }

Original file line number	Diff line number	Diff line change
`@@ -83,11 +83,11 @@ private class EncryptedSharedPrefFlowConfig extends DataFlow4::Configuration {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`override predicate isSource(DataFlow4::Node src) {`
`86`		`- src.asExpr().(MethodAccess).getMethod() instanceof SharedPreferences::CreateEncryptedPrefsMethod`
	`86`	`+ src.asExpr().(MethodAccess).getMethod() instanceof SharedPreferences::CreateEncryptedMethod`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`override predicate isSink(DataFlow4::Node sink) {`
`90`		`- sink.asExpr().getType() instanceof SharedPreferences::TypePrefs`
	`90`	`+ sink.asExpr().getType() instanceof SharedPreferences::TypeBase`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`