Apply suggestions from code review

aibaars · nickrolfe · web-flow · commit f2ec5132bad1 · 2022-03-16T14:46:34.000+01:00
Co-authored-by: Nick Rolfe &lt;nickrolfe@github.com&gt;
diff --git a/ruby/ql/lib/codeql/ruby/InclusionTests.qll b/ruby/ql/lib/codeql/ruby/InclusionTests.qll
@@ -38,7 +38,7 @@ class InclusionTest extends DataFlow::Node instanceof InclusionTest::Range {
  */
 module InclusionTest {
   /**
-   * A expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
+   * An expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
    *
    * Note that this also includes calls to the array method named `include?`.
    */
diff --git a/ruby/ql/lib/codeql/ruby/StringOps.qll b/ruby/ql/lib/codeql/ruby/StringOps.qll
@@ -104,7 +104,7 @@ module StringOps {
   }
 
   /**
-   * A expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
+   * An expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
    * Note that this class is equivalent to `InclusionTest`, which also matches
    * inclusion tests on array objects.
    */
diff --git a/ruby/ql/src/queries/security/cwe-020/examples/IncompleteUrlSubstringSanitization_BAD1.rb b/ruby/ql/src/queries/security/cwe-020/examples/IncompleteUrlSubstringSanitization_BAD1.rb
@@ -4,5 +4,6 @@ def index
         # BAD: the host of `url` may be controlled by an attacker
         if url.include?("example.com")
             redirect_to url
+        end
     end
 end

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ class InclusionTest extends DataFlow::Node instanceof InclusionTest::Range {`
`38`	`38`	`*/`
`39`	`39`	`module InclusionTest {`
`40`	`40`	`/**`
`41`		- * A expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
	`41`	+ * An expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
`42`	`42`	`*`
`43`	`43`	* Note that this also includes calls to the array method named `include?`.
`44`	`44`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ module StringOps {`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`/**`
`107`		- * A expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
	`107`	+ * An expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
`108`	`108`	* Note that this class is equivalent to `InclusionTest`, which also matches
`109`	`109`	`* inclusion tests on array objects.`
`110`	`110`	`*/`