ruby: remove redundant cases

yoff · yoff · commit f675a143d6f6 · 2025-04-11T10:48:41.000+02:00
The CFG handles the negation
diff --git a/ruby/ql/src/queries/variables/UninitializedLocal.ql b/ruby/ql/src/queries/variables/UninitializedLocal.ql
@@ -37,23 +37,12 @@ predicate isGuarded(LocalVariableReadAccess read) {
     guard.getAstNode() = read.getVariable().getAnAccess() and
     branch = true
     or
-    // guard is `!var`
-    guard.getAstNode().(NotExpr).getOperand() = read.getVariable().getAnAccess() and
-    branch = false
-    or
     // guard is `var.nil?`
     exists(MethodCall c | guard.getAstNode() = c |
       c.getReceiver() = read.getVariable().getAnAccess() and
       c.getMethodName() = "nil?"
     ) and
     branch = false
-    or
-    // guard is `!var.nil?`
-    exists(MethodCall c | guard.getAstNode().(NotExpr).getOperand() = c |
-      c.getReceiver() = read.getVariable().getAnAccess() and
-      c.getMethodName() = "nil?"
-    ) and
-    branch = true
   )
 }
 
