C++: Fixed incorrect comments in testcases

MathiasVP · MathiasVP · commit f80c13abd7c4 · 2020-01-10T12:24:43.000+01:00
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/AssignWhereCompareMeant/test.cpp b/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/AssignWhereCompareMeant/test.cpp
@@ -126,7 +126,7 @@ void f2() {
 }
 
 void f3(int x, int y) {
-  if(x == 1 && (y = 2)) { // GOOD [FALSE POSITIVE]: the programmer seems to be okay with unparenthesized
+  if(x == 1 && (y = 2)) { // GOOD: the programmer seems to be okay with unparenthesized
                           // comparison operands, so the parenthesis was used to mark this
                           // as an assignment
   }
@@ -138,13 +138,13 @@ void f3(int x, int y) {
   if(((z == 42) || (y = 2)) && (x == 1)) { // BAD
   }
 
-  if((y = 2) && (x == z || x == 1)) { // GOOD [FALSE POSITIVE]
+  if((y = 2) && (x == z || x == 1)) { // GOOD
   }
 
   if(((x == 42) || x == 1) && (y = 2)) { // BAD
   }
 
-  if(x == 10 || (x == 42 && x == 1) && (y = 2)) { // GOOD [FALSE POSITIVE]
+  if(x == 10 || (x == 42 && x == 1) && (y = 2)) { // GOOD
   }
 
   if(x == 10 || ((x == 42) && (y = 2)) && (z == 1)) { // BAD

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ void f2() {`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`void f3(int x, int y) {`
`129`		`- if(x == 1 && (y = 2)) { // GOOD [FALSE POSITIVE]: the programmer seems to be okay with unparenthesized`
	`129`	`+ if(x == 1 && (y = 2)) { // GOOD: the programmer seems to be okay with unparenthesized`
`130`	`130`	`// comparison operands, so the parenthesis was used to mark this`
`131`	`131`	`// as an assignment`
`132`	`132`	`}`
`@@ -138,13 +138,13 @@ void f3(int x, int y) {`
`138`	`138`	`if(((z == 42) \|\| (y = 2)) && (x == 1)) { // BAD`
`139`	`139`	`}`
`140`	`140`
`141`		`- if((y = 2) && (x == z \|\| x == 1)) { // GOOD [FALSE POSITIVE]`
	`141`	`+ if((y = 2) && (x == z \|\| x == 1)) { // GOOD`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`if(((x == 42) \|\| x == 1) && (y = 2)) { // BAD`
`145`	`145`	`}`
`146`	`146`
`147`		`- if(x == 10 \|\| (x == 42 && x == 1) && (y = 2)) { // GOOD [FALSE POSITIVE]`
	`147`	`+ if(x == 10 \|\| (x == 42 && x == 1) && (y = 2)) { // GOOD`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`if(x == 10 \|\| ((x == 42) && (y = 2)) && (z == 1)) { // BAD`