Address review comment about ignored QL variable

kaspersv · aschackmull · web-flow · commit f84a3084f065 · 2025-07-15T15:34:08.000+02:00
Co-authored-by: Anders Schack-Mulligen &lt;aschackmull@users.noreply.github.com&gt;
diff --git a/java/ql/lib/semmle/code/java/Overlay.qll b/java/ql/lib/semmle/code/java/Overlay.qll
@@ -83,7 +83,7 @@ private predicate discardReferableLocatable(@locatable el) {
 }
 
 overlay[local]
-private predicate baseConfigLocatable(@configLocatable l) { not isOverlay() and l = l }
+private predicate baseConfigLocatable(@configLocatable l) { not isOverlay() and exists(l) }
 
 overlay[local]
 private predicate overlayHasConfigLocatables() {

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ private predicate discardReferableLocatable(@locatable el) {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`overlay[local]`
`86`		`-private predicate baseConfigLocatable(@configLocatable l) { not isOverlay() and l = l }`
	`86`	`+private predicate baseConfigLocatable(@configLocatable l) { not isOverlay() and exists(l) }`
`87`	`87`
`88`	`88`	`overlay[local]`
`89`	`89`	`private predicate overlayHasConfigLocatables() {`