C++/C#: document isThisIndirection and sync files

Robert Marsh · Robert Marsh · commit f8cfcef9c9ac · 2020-05-29T09:52:03.000-07:00
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll
@@ -542,6 +542,9 @@ class ReturnIndirectionInstruction extends VariableInstruction {
    */
   final Language::Parameter getParameter() { result = var.(IRUserVariable).getVariable() }
 
+  /**
+   * Holds if this instruction is the return indirection for `this`.
+   */
   final predicate isThisIndirection() { var instanceof IRThisVariable }
 }
 
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll
@@ -541,6 +541,11 @@ class ReturnIndirectionInstruction extends VariableInstruction {
    * function.
    */
   final Language::Parameter getParameter() { result = var.(IRUserVariable).getVariable() }
+
+  /**
+   * Holds if this instruction is the return indirection for `this`.
+   */
+  final predicate isThisIndirection() { var instanceof IRThisVariable }
 }
 
 class CopyInstruction extends Instruction {
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll
@@ -541,6 +541,11 @@ class ReturnIndirectionInstruction extends VariableInstruction {
    * function.
    */
   final Language::Parameter getParameter() { result = var.(IRUserVariable).getVariable() }
+
+  /**
+   * Holds if this instruction is the return indirection for `this`.
+   */
+  final predicate isThisIndirection() { var instanceof IRThisVariable }
 }
 
 class CopyInstruction extends Instruction {
diff --git a/csharp/ql/src/semmle/code/csharp/ir/implementation/raw/Instruction.qll b/csharp/ql/src/semmle/code/csharp/ir/implementation/raw/Instruction.qll
@@ -541,6 +541,11 @@ class ReturnIndirectionInstruction extends VariableInstruction {
    * function.
    */
   final Language::Parameter getParameter() { result = var.(IRUserVariable).getVariable() }
+
+  /**
+   * Holds if this instruction is the return indirection for `this`.
+   */
+  final predicate isThisIndirection() { var instanceof IRThisVariable }
 }
 
 class CopyInstruction extends Instruction {
diff --git a/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/Instruction.qll b/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/Instruction.qll
@@ -541,6 +541,11 @@ class ReturnIndirectionInstruction extends VariableInstruction {
    * function.
    */
   final Language::Parameter getParameter() { result = var.(IRUserVariable).getVariable() }
+
+  /**
+   * Holds if this instruction is the return indirection for `this`.
+   */
+  final predicate isThisIndirection() { var instanceof IRThisVariable }
 }
 
 class CopyInstruction extends Instruction {

Original file line number	Diff line number	Diff line change
`@@ -542,6 +542,9 @@ class ReturnIndirectionInstruction extends VariableInstruction {`
`542`	`542`	`*/`
`543`	`543`	`final Language::Parameter getParameter() { result = var.(IRUserVariable).getVariable() }`
`544`	`544`
	`545`	`+ /**`
	`546`	+ * Holds if this instruction is the return indirection for `this`.
	`547`	`+ */`
`545`	`548`	`final predicate isThisIndirection() { var instanceof IRThisVariable }`
`546`	`549`	`}`
`547`	`550`