Kotlin: Use trace (silently for now) rather than info for writing TRAP files

igfoo · igfoo · commit f95934a0c53a · 2022-05-10T19:50:58.000+01:00
The on-demand "Writing trap file for: " messages are drowning out
everything else while running the tests.
diff --git a/java/kotlin-extractor/src/main/java/com/semmle/extractor/java/OdasaOutput.java b/java/kotlin-extractor/src/main/java/com/semmle/extractor/java/OdasaOutput.java
@@ -278,13 +278,13 @@ private TrapFileManager getMembersWriterForClass(IrClass sym) {
 			if (!currVersion.isValid()) {
 				log.warn("Not rewriting trap file for: " + sym + " " + trapVersion + " " + currVersion + " " + trap);
 			} else if (currVersion.newerThan(trapVersion)) {
-				log.info("Rewriting trap file for: " + sym + " " + trapVersion + " " + currVersion + " " + trap);
+				log.trace("Rewriting trap file for: " + sym + " " + trapVersion + " " + currVersion + " " + trap);
 				deleteTrapFileAndDependencies(sym);
 			} else {
 				return null;
 			}
 		} else {
-			log.info("Writing trap file for: " + sym.getName() + " " + currVersion + " " + trap);
+			log.trace("Writing trap file for: " + sym.getName() + " " + currVersion + " " + trap);
 		}
 		return trapWriter(trap, sym);
 	}
diff --git a/java/kotlin-extractor/src/main/kotlin/utils/Logger.kt b/java/kotlin-extractor/src/main/kotlin/utils/Logger.kt
@@ -43,13 +43,15 @@ open class Logger(val logCounter: LogCounter, open val tw: TrapWriter) {
         println(fullMsg)
     }
     fun trace(msg: String) {
-        info(msg)
+        if(false) {
+            info(msg)
+        }
     }
     fun debug(msg: String) {
         info(msg)
     }
     fun trace(msg: String, exn: Exception) {
-        info(msg + " // " + exn)
+        trace(msg + " // " + exn)
     }
     fun warn(severity: Severity, msg: String, locationString: String? = null, locationId: Label<DbLocation> = tw.unknownLocation, stackIndex: Int = 2) {
         val st = Exception().stackTrace

Original file line number	Diff line number	Diff line change
`@@ -278,13 +278,13 @@ private TrapFileManager getMembersWriterForClass(IrClass sym) {`
`278`	`278`	`if (!currVersion.isValid()) {`
`279`	`279`	`log.warn("Not rewriting trap file for: " + sym + " " + trapVersion + " " + currVersion + " " + trap);`
`280`	`280`	`} else if (currVersion.newerThan(trapVersion)) {`
`281`		`- log.info("Rewriting trap file for: " + sym + " " + trapVersion + " " + currVersion + " " + trap);`
	`281`	`+ log.trace("Rewriting trap file for: " + sym + " " + trapVersion + " " + currVersion + " " + trap);`
`282`	`282`	`deleteTrapFileAndDependencies(sym);`
`283`	`283`	`} else {`
`284`	`284`	`return null;`
`285`	`285`	`}`
`286`	`286`	`} else {`
`287`		`- log.info("Writing trap file for: " + sym.getName() + " " + currVersion + " " + trap);`
	`287`	`+ log.trace("Writing trap file for: " + sym.getName() + " " + currVersion + " " + trap);`
`288`	`288`	`}`
`289`	`289`	`return trapWriter(trap, sym);`
`290`	`290`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,13 +43,15 @@ open class Logger(val logCounter: LogCounter, open val tw: TrapWriter) {`
`43`	`43`	`println(fullMsg)`
`44`	`44`	`}`
`45`	`45`	`fun trace(msg: String) {`
`46`		`- info(msg)`
	`46`	`+ if(false) {`
	`47`	`+ info(msg)`
	`48`	`+ }`
`47`	`49`	`}`
`48`	`50`	`fun debug(msg: String) {`
`49`	`51`	`info(msg)`
`50`	`52`	`}`
`51`	`53`	`fun trace(msg: String, exn: Exception) {`
`52`		`- info(msg + " // " + exn)`
	`54`	`+ trace(msg + " // " + exn)`
`53`	`55`	`}`
`54`	`56`	`fun warn(severity: Severity, msg: String, locationString: String? = null, locationId: Label<DbLocation> = tw.unknownLocation, stackIndex: Int = 2) {`
`55`	`57`	`val st = Exception().stackTrace`