C++: Remove redundant check.

geoffw0 · geoffw0 · commit f9a7322d6854 · 2020-12-14T17:16:16.000Z
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/Swap.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/Swap.qll
@@ -29,7 +29,6 @@ private class MemberSwap extends TaintFunction, MemberFunction {
   MemberSwap() {
     this.hasName("swap") and
     this.getNumberOfParameters() = 1 and
-    this.getParameter(0).getType() instanceof ReferenceType and
     this.getParameter(0).getType().(ReferenceType).getBaseType().getUnspecifiedType() =
       getDeclaringType()
   }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@ private class MemberSwap extends TaintFunction, MemberFunction {`
`29`	`29`	`MemberSwap() {`
`30`	`30`	`this.hasName("swap") and`
`31`	`31`	`this.getNumberOfParameters() = 1 and`
`32`		`- this.getParameter(0).getType() instanceof ReferenceType and`
`33`	`32`	`this.getParameter(0).getType().(ReferenceType).getBaseType().getUnspecifiedType() =`
`34`	`33`	`getDeclaringType()`
`35`	`34`	`}`