Python: Fix bug pointed out by reviewer

yoff · yoff · commit f9b1c5e4bd4e · 2020-08-21T10:04:27.000+02:00
diff --git a/python/ql/src/experimental/dataflow/internal/DataFlowPrivate.qll b/python/ql/src/experimental/dataflow/internal/DataFlowPrivate.qll
@@ -425,7 +425,7 @@ predicate comprehensionReadStep(CfgNode nodeFrom, Content c, EssaNode nodeTo) {
   //   c denotes element of list or set
   exists(For f, Comp comp |
     f = getCompFor(comp) and
-    nodeFrom.getNode().(SequenceNode).getNode() = getCompIter(comp) and
+    nodeFrom.getNode().getNode() = getCompIter(comp) and
     nodeTo.getVar().getDefinition().(AssignmentDefinition).getDefiningNode().getNode() =
       f.getTarget() and
     (

Original file line number	Diff line number	Diff line change
`@@ -425,7 +425,7 @@ predicate comprehensionReadStep(CfgNode nodeFrom, Content c, EssaNode nodeTo) {`
`425`	`425`	`// c denotes element of list or set`
`426`	`426`	`exists(For f, Comp comp \|`
`427`	`427`	`f = getCompFor(comp) and`
`428`		`- nodeFrom.getNode().(SequenceNode).getNode() = getCompIter(comp) and`
	`428`	`+ nodeFrom.getNode().getNode() = getCompIter(comp) and`
`429`	`429`	`nodeTo.getVar().getDefinition().(AssignmentDefinition).getDefiningNode().getNode() =`
`430`	`430`	`f.getTarget() and`
`431`	`431`	`(`