JS: Replace an exists+concat with an equivalent strictconcat

adityasharad · adityasharad · commit fac2769d852b · 2021-12-03T14:20:26.000-08:00
diff --git a/javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointFeatures.qll b/javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointFeatures.qll
@@ -25,9 +25,8 @@ private string getTokenFeature(DataFlow::Node endpoint, string featureName) {
     result = unique(string x | x = FunctionBodies::getBodyTokenFeatureForEntity(entity))
   )
   or
-  exists(getACallBasedTokenFeatureComponent(endpoint, _, featureName)) and
   result =
-    concat(DataFlow::CallNode call, string component |
+    strictconcat(DataFlow::CallNode call, string component |
       component = getACallBasedTokenFeatureComponent(endpoint, call, featureName)
     |
       component, " "

Original file line number	Diff line number	Diff line change
`@@ -25,9 +25,8 @@ private string getTokenFeature(DataFlow::Node endpoint, string featureName) {`
`25`	`25`	`result = unique(string x \| x = FunctionBodies::getBodyTokenFeatureForEntity(entity))`
`26`	`26`	`)`
`27`	`27`	`or`
`28`		`- exists(getACallBasedTokenFeatureComponent(endpoint, _, featureName)) and`
`29`	`28`	`result =`
`30`		`- concat(DataFlow::CallNode call, string component \|`
	`29`	`+ strictconcat(DataFlow::CallNode call, string component \|`
`31`	`30`	`component = getACallBasedTokenFeatureComponent(endpoint, call, featureName)`
`32`	`31`	`\|`
`33`	`32`	`component, " "`