[CPP-434] Move SignedOverflowCheck test to BadAdditionOverflowCheck directory; add additional tests.

zlaski-semmle · zlaski-semmle · commit fb625c12ef7d · 2019-10-16T14:31:11.000-07:00
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/BadAdditionOverflowCheck/BadAdditionOverflowCheck.expected b/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/BadAdditionOverflowCheck/BadAdditionOverflowCheck.expected
@@ -1 +1,3 @@
+| SignedOverflowCheck.cpp:35:9:35:23 | ... < ... | Bad overflow check. |
+| SignedOverflowCheck.cpp:113:12:113:66 | ... < ... | Bad overflow check. |
 | test.cpp:3:11:3:19 | ... < ... | Bad overflow check. |
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/BadAdditionOverflowCheck/SignedOverflowCheck.cpp b/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/BadAdditionOverflowCheck/SignedOverflowCheck.cpp
@@ -98,3 +98,17 @@ int overflow12(int n) {
     // not deleted by gcc or clang
 	return (n + 32 <= (unsigned)n? -1: 1); // BAD
 }
+
+bool multipleCasts(char x) {
+    // clang 9.0.0 -O2: deleted
+    // gcc 9.2 -O2: deleted
+    // msvc 19.22 /O2: deleted
+    return (int)(unsigned short)x + 2 < (int)(unsigned short)x; // BAD
+}
+
+bool multipleCasts2(char x) {
+    // clang 9.0.0 -O2: not deleted
+    // gcc 9.2 -O2: not deleted
+    // msvc 19.22 /O2: not deleted
+    return (int)(unsigned short)(x + '1') < (int)(unsigned short)x; // GOOD [FALSE POSITIVE]
+}
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/BadAdditionOverflowCheck/SignedOverflowCheck.expected b/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/BadAdditionOverflowCheck/SignedOverflowCheck.expected
@@ -2,3 +2,6 @@
 | SignedOverflowCheck.cpp:18:12:18:26 | ... < ... | Testing for signed overflow may produce undefined results. |
 | SignedOverflowCheck.cpp:35:9:35:23 | ... < ... | Testing for signed overflow may produce undefined results. |
 | SignedOverflowCheck.cpp:99:10:99:30 | ... <= ... | Testing for signed overflow may produce undefined results. |
+| SignedOverflowCheck.cpp:106:12:106:62 | ... < ... | Testing for signed overflow may produce undefined results. |
+| SignedOverflowCheck.cpp:113:12:113:66 | ... < ... | Testing for signed overflow may produce undefined results. |
+| test.cpp:3:11:3:19 | ... < ... | Testing for signed overflow may produce undefined results. |
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/BadAdditionOverflowCheck/SignedOverflowCheck.qlref b/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/BadAdditionOverflowCheck/SignedOverflowCheck.qlref

Original file line number	Diff line number	Diff line change
`@@ -1 +1,3 @@`
	`1`	`+\| SignedOverflowCheck.cpp:35:9:35:23 \| ... < ... \| Bad overflow check. \|`
	`2`	`+\| SignedOverflowCheck.cpp:113:12:113:66 \| ... < ... \| Bad overflow check. \|`
`1`	`3`	`\| test.cpp:3:11:3:19 \| ... < ... \| Bad overflow check. \|`