Apply suggestions from code review

tausbn · shati-patel · web-flow · commit ffe5d30c2b99 · 2021-03-12T14:27:07.000+01:00
Co-authored-by: Shati Patel &lt;42641846+shati-patel@users.noreply.github.com&gt;
diff --git a/python/ql/src/Security/CVE-2018-1281/BindToAllInterfaces.ql b/python/ql/src/Security/CVE-2018-1281/BindToAllInterfaces.ql
@@ -54,7 +54,7 @@ DataFlow::Node vulnerableHostnameRef(string hostname) {
   vulnerableHostnameRef(DataFlow::TypeTracker::end(), hostname).flowsTo(result)
 }
 
-/** Gets a reference to tuple containing a hostname as the first element, that can be used to bind to all interfaces. */
+/** Gets a reference to a tuple containing a hostname as the first element, that can be used to bind to all interfaces. */
 private DataFlow::LocalSourceNode vulnerableAddressTuple(DataFlow::TypeTracker t, string hostname) {
   t.start() and
   result.asExpr() = any(Tuple tup | tup.getElt(0) = vulnerableHostnameRef(hostname).asExpr())
@@ -76,7 +76,7 @@ private predicate vulnerableAddressTuple_first_join(
   DataFlow::StepSummary::step(vulnerableAddressTuple(t2, hostname), res, summary)
 }
 
-/** Gets a reference to tuple containing a hostname as the first element, that can be used to bind to all interfaces. */
+/** Gets a reference to a tuple containing a hostname as the first element, that can be used to bind to all interfaces. */
 DataFlow::Node vulnerableAddressTuple(string hostname) {
   vulnerableAddressTuple(DataFlow::TypeTracker::end(), hostname).flowsTo(result)
 }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ DataFlow::Node vulnerableHostnameRef(string hostname) {`
`54`	`54`	`vulnerableHostnameRef(DataFlow::TypeTracker::end(), hostname).flowsTo(result)`
`55`	`55`	`}`
`56`	`56`
`57`		`-/** Gets a reference to tuple containing a hostname as the first element, that can be used to bind to all interfaces. */`
	`57`	`+/** Gets a reference to a tuple containing a hostname as the first element, that can be used to bind to all interfaces. */`
`58`	`58`	`private DataFlow::LocalSourceNode vulnerableAddressTuple(DataFlow::TypeTracker t, string hostname) {`
`59`	`59`	`t.start() and`
`60`	`60`	`result.asExpr() = any(Tuple tup \| tup.getElt(0) = vulnerableHostnameRef(hostname).asExpr())`
`@@ -76,7 +76,7 @@ private predicate vulnerableAddressTuple_first_join(`
`76`	`76`	`DataFlow::StepSummary::step(vulnerableAddressTuple(t2, hostname), res, summary)`
`77`	`77`	`}`
`78`	`78`
`79`		`-/** Gets a reference to tuple containing a hostname as the first element, that can be used to bind to all interfaces. */`
	`79`	`+/** Gets a reference to a tuple containing a hostname as the first element, that can be used to bind to all interfaces. */`
`80`	`80`	`DataFlow::Node vulnerableAddressTuple(string hostname) {`
`81`	`81`	`vulnerableAddressTuple(DataFlow::TypeTracker::end(), hostname).flowsTo(result)`
`82`	`82`	`}`