Merge pull request #3160 from github/mbg/fix/upload-sarif

mbg · web-flow · commit 0a67bd46a0f4 · 2025-09-26T18:06:08.000+01:00
Hotfix `upload-sarif` not uploading non-`.sarif` files
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,7 +4,7 @@ See the [releases page](https://github.com/github/codeql-action/releases) for th
 
 ## [UNRELEASED]
 
-No user facing changes.
+- We fixed a bug that was introduced in `3.30.4` with `upload-sarif` which resulted in files without a `.sarif` extension not getting uploaded. [#3160](https://github.com/github/codeql-action/pull/3160)
 
 ## 3.30.4 - 25 Sep 2025
 
diff --git a/lib/upload-sarif-action.js b/lib/upload-sarif-action.js
diff --git a/src/upload-sarif-action.ts b/src/upload-sarif-action.ts
@@ -61,7 +61,12 @@ async function findAndUpload(
       sarifPath,
       analysis.sarifPredicate,
     );
-  } else if (pathStats.isFile() && analysis.sarifPredicate(sarifPath)) {
+  } else if (
+    pathStats.isFile() &&
+    (analysis.sarifPredicate(sarifPath) ||
+      (analysis.kind === analyses.AnalysisKind.CodeScanning &&
+        !analyses.CodeQuality.sarifPredicate(sarifPath)))
+  ) {
     sarifFiles = [sarifPath];
   } else {
     return undefined;
