Address issue with JDK on Linux

rvermeulen · rvermeulen · commit f80e31e04ff1 · 2024-01-29T14:02:09.000-08:00
This uses the same approach as the CodeQL derivative part of Nix packages https://github.com/NixOS/nixpkgs/blob/4299aee00ffcb68ecdc5c9a2befc244a61bec5be/pkgs/development/tools/analysis/codeql/default.nix
diff --git a/tooling/codeql/codeql-cli/2.16.0.nix b/tooling/codeql/codeql-cli/2.16.0.nix
@@ -1,4 +1,4 @@
-{ lib, stdenv, fetchzip, withExtractors ? [], withPacks ? [] }:
+{ lib, stdenv, fetchzip, jdk17, withExtractors ? [], withPacks ? [] }:
 
 stdenv.mkDerivation rec {
   pname = "codeql-cli";
@@ -17,12 +17,27 @@ stdenv.mkDerivation rec {
   buildInputs = if (lib.length withExtractors)  == 0 then [ ] else withExtractors;
   inherit withExtractors withPacks;
 
+  nativeBuildInputs = [ jdk17 ];
+
   installPhase = ''
     # codeql directory should not be top-level, otherwise,
     # it'll include /nix/store to resolve extractors.
     mkdir -p $out/{codeql/qlpacks,bin}
     cp -R * $out/codeql/
 
+
+    if [ "$platform" == "linux64" ]; then
+      ln -sf $out/codeql/tools/linux64/lib64trace.so $out/codeql/tools/linux64/libtrace.so
+    fi
+      
+    # many of the codeql extractors use CODEQL_DIST + CODEQL_PLATFORM to
+    # resolve java home, so to be able to create databases, we want to make
+    # sure that they point somewhere sane/usable since we can not autopatch
+    # the codeql packaged java dist, but we DO want to patch the extractors
+    # as well as the builders which are ELF binaries for the most part
+    rm -rf $out/codeql/tools/$platform/java
+    ln -s ${jdk17} $out/codeql/tools/$platform/java
+
     ln -s $out/codeql/codeql $out/bin/
 
     for extractor in $withExtractors; do
