Set roles if non has been set

muan · muan · commit 567226ba289b · 2019-09-09T15:39:43.000-04:00
- Setting role=menu only if one doesn't exsit already
- Setting role=button on summary to perform as a menu button
diff --git a/index.js b/index.js
@@ -26,13 +26,16 @@ class DetailsMenuElement extends HTMLElement {
   }
 
   connectedCallback() {
-    this.setAttribute('role', 'menu')
+    if (!this.hasAttribute('role')) this.setAttribute('role', 'menu')
 
     const details = this.parentElement
     if (!details) return
 
     const summary = details.querySelector('summary')
-    if (summary) summary.setAttribute('aria-haspopup', 'menu')
+    if (summary) {
+      summary.setAttribute('aria-haspopup', 'menu')
+      if (!summary.hasAttribute('role')) summary.setAttribute('role', 'button')
+    }
 
     details.addEventListener('click', shouldCommit)
     details.addEventListener('change', shouldCommit)
