remove remnants of the disk-based redirects cache file (#31445)

Peter Bengtsson · web-flow · commit 8b1fb6ec2a4a · 2022-10-05T16:51:14.000Z
diff --git a/.gitignore b/.gitignore
@@ -19,10 +19,9 @@ coverage/
 blc_output.log
 blc_output_internal.log
 broken_links.md
-lib/redirects/.redirects-cache.json
 # This one is purely for historical reasons because so many people might
-# still have thes files on their disk.
-lib/redirects/.redirects-cache_*.json
+# still have these files on their disk.
+lib/redirects/.redirects-cache*.json
 
 # During the preview deploy untrusted user code may be cloned into this directory
 # We ignore it from git to keep things deterministic
diff --git a/lib/redirects/static/redirect-exceptions.txt b/lib/redirects/static/redirect-exceptions.txt
@@ -1,8 +1,3 @@
-# Redirects are cached in 'lib/redirects/.redirects-cache.json'. If changes made here are not being reflected
-# on your local server, delete the cache file by running the following command, then restart your server.
-#
-#   rm lib/redirects/.redirects-cache.json
-
 # These urls are exceptions to the versionless redirect fallbacks (described in lib/all-versions.js).
 # See the comment in lib/redirects/precompile.js for an explanation of these exceptions.
 # Originally shipped in pull #20947 on 10/15/21
diff --git a/script/move-content.js b/script/move-content.js
@@ -155,18 +155,6 @@ async function main(opts, nameTuple) {
       )
     }
   }
-
-  const redirectsCachingFile = 'lib/redirects/.redirects-cache.json'
-  if (fs.existsSync(redirectsCachingFile)) {
-    fs.unlinkSync(redirectsCachingFile)
-    if (verbose) {
-      console.log(
-        chalk.yellow(
-          `Deleted the redirects caching file ${redirectsCachingFile} to stale cache in local server testing.`
-        )
-      )
-    }
-  }
 }
 
 function validateFileInputs(oldPath, newPath, isFolder) {
diff --git a/tests/fixtures/versionless-redirects.txt b/tests/fixtures/versionless-redirects.txt
@@ -1,8 +1,3 @@
-# Redirects are cached in 'lib/redirects/.redirects-cache.json'. If changes made here are not being reflected
-# on your local server, delete the cache file by running the following command, then restart your server.
-#
-#   rm lib/redirects/.redirects-cache.json
-
 # These urls went from being free-pro-team, but are now versioned for more than one enterprise version and enterprise-cloud
 # Shipped in pull #20947 on 10/15/21
 
@@ -145,7 +140,7 @@
 - /github/setting-up-and-managing-your-enterprise/configuring-identity-and-access-management-for-your-enterprise-account
 - /admin/authentication/managing-identity-and-access-for-your-enterprise
 
-# These URLs went from being in free-pro-team to ONLY to being in enterprise-cloud only. 
+# These URLs went from being in free-pro-team to ONLY to being in enterprise-cloud only.
 # Shipped in pull #20947 on 10/15/21
 
 /enterprise-cloud@latest/admin/identity-and-access-management/using-saml-for-enterprise-iam/managing-team-synchronization-for-organizations-in-your-enterprise
@@ -278,7 +273,7 @@
 # - lib/github/private_instance_bootstrapper/internal_support_contact.rb
 # - lib/github/private_instance_bootstrapper/saml_idp_configuration.rb
 # - lib/github/private_instance_bootstrapper/policies_configuration.rb
-# This redirect ensures that the links don't resolve to the non-GHAE version 
+# This redirect ensures that the links don't resolve to the non-GHAE version
 # of the docs as this article only exists in the GHAE docs.
 
 /github-ae@latest/admin/configuration/configuring-your-enterprise/initializing-github-ae

Original file line number	Diff line number	Diff line change
`@@ -155,18 +155,6 @@ async function main(opts, nameTuple) {`
`155`	`155`	`)`
`156`	`156`	`}`
`157`	`157`	`}`
`158`		`-`
`159`		`- const redirectsCachingFile = 'lib/redirects/.redirects-cache.json'`
`160`		`- if (fs.existsSync(redirectsCachingFile)) {`
`161`		`- fs.unlinkSync(redirectsCachingFile)`
`162`		`- if (verbose) {`
`163`		`- console.log(`
`164`		`- chalk.yellow(`
`165`		- `Deleted the redirects caching file ${redirectsCachingFile} to stale cache in local server testing.`
`166`		`- )`
`167`		`- )`
`168`		`- }`
`169`		`- }`
`170`	`158`	`}`
`171`	`159`
`172`	`160`	`function validateFileInputs(oldPath, newPath, isFolder) {`