Move eslint.config.js to Typescript (#58027)

heiskr · web-flow · commit bba2c9cd79f0 · 2025-10-22T19:06:03.000Z
diff --git a/eslint-plugins.d.ts b/eslint-plugins.d.ts
@@ -0,0 +1,57 @@
+// Type declarations for ESLint plugins without official TypeScript definitions
+
+declare module 'eslint-plugin-github' {
+  import type { ESLint, Linter } from 'eslint'
+
+  const plugin: ESLint.Plugin & {
+    configs: {
+      recommended: Linter.FlatConfig
+    }
+  }
+
+  export default plugin
+}
+
+declare module 'eslint-plugin-primer-react' {
+  import type { ESLint, Linter } from 'eslint'
+
+  const plugin: ESLint.Plugin & {
+    configs: {
+      recommended: Linter.FlatConfig
+    }
+  }
+
+  export default plugin
+}
+
+declare module 'eslint-plugin-eslint-comments' {
+  import type { ESLint } from 'eslint'
+
+  const plugin: ESLint.Plugin
+
+  export default plugin
+}
+
+declare module 'eslint-plugin-i18n-text' {
+  import type { ESLint } from 'eslint'
+
+  const plugin: ESLint.Plugin
+
+  export default plugin
+}
+
+declare module 'eslint-plugin-filenames' {
+  import type { ESLint } from 'eslint'
+
+  const plugin: ESLint.Plugin
+
+  export default plugin
+}
+
+declare module 'eslint-plugin-no-only-tests' {
+  import type { ESLint } from 'eslint'
+
+  const plugin: ESLint.Plugin
+
+  export default plugin
+}
diff --git a/eslint.config.ts b/eslint.config.ts
@@ -14,89 +14,6 @@ import prettier from 'eslint-config-prettier'
 import globals from 'globals'
 
 export default [
-  // JavaScript and MJS files configuration
-  {
-    files: ['**/*.{js,mjs}'],
-    languageOptions: {
-      ecmaVersion: 2022,
-      sourceType: 'module',
-      globals: {
-        ...globals.browser,
-        ...globals.node,
-        ...globals.commonjs,
-        ...globals.es2020,
-      },
-      parserOptions: {
-        requireConfigFile: false,
-      },
-    },
-    settings: {
-      'import/resolver': {
-        typescript: true,
-        node: true,
-      },
-    },
-    plugins: {
-      github,
-      import: importPlugin,
-      'eslint-comments': eslintComments,
-      'i18n-text': i18nText,
-      filenames,
-      'no-only-tests': noOnlyTests,
-      prettier: prettierPlugin,
-    },
-    rules: {
-      // ESLint recommended rules
-      ...js.configs.recommended.rules,
-
-      // GitHub plugin recommended rules
-      ...github.configs.recommended.rules,
-
-      // Import plugin error rules
-      ...importPlugin.configs.errors.rules,
-
-      // JavaScript-specific overrides
-      'import/no-extraneous-dependencies': [
-        'error',
-        {
-          packageDir: '.',
-        },
-      ],
-      'import/extensions': 'off',
-      'no-console': 'off',
-      camelcase: 'off',
-      'no-shadow': 'off',
-      'prefer-template': 'off',
-      'no-constant-condition': 'off',
-      'no-unused-vars': 'off',
-      'import/no-named-as-default-member': 'off',
-      'one-var': 'off',
-      'import/no-namespace': 'off',
-      'import/no-anonymous-default-export': 'off',
-      'object-shorthand': 'off',
-      'no-empty': 'off',
-      'prefer-const': 'off',
-      'import/no-named-as-default': 'off',
-      'no-useless-concat': 'off',
-      'func-style': 'off',
-
-      // Disable GitHub plugin rules that were disabled in original config
-      'github/array-foreach': 'off',
-      'github/no-then': 'off',
-
-      // Disable rules that might not exist or cause issues initially
-      'i18n-text/no-en': 'off',
-      'filenames/match-regex': 'off',
-      'eslint-comments/no-use': 'off',
-      'eslint-comments/no-unused-disable': 'off',
-      'eslint-comments/no-unlimited-disable': 'off',
-
-      // Disable new ESLint 9 rules that are causing issues
-      'no-constant-binary-expression': 'off',
-    },
-  },
-
-  // TypeScript and TSX files configuration
   {
     files: ['**/*.{ts,tsx}'],
     languageOptions: {
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -258,6 +258,7 @@
     "@types/connect-timeout": "1.9.0",
     "@types/cookie": "0.6.0",
     "@types/cookie-parser": "1.4.8",
+    "@types/eslint-plugin-jsx-a11y": "^6.10.1",
     "@types/event-to-promise": "^0.7.5",
     "@types/express": "^5.0.3",
     "@types/imurmurhash": "^0.1.4",
@@ -298,6 +299,7 @@
     "graphql": "^16.9.0",
     "http-status-code": "^2.1.0",
     "husky": "^9.1.7",
+    "jiti": "^2.6.1",
     "json-schema-merge-allof": "^0.8.1",
     "lint-staged": "^16.0.0",
     "markdownlint": "^0.34.0",
diff --git a/src/ai-tools/scripts/ai-tools.ts b/src/ai-tools/scripts/ai-tools.ts
@@ -1,5 +1,3 @@
-#!/usr/bin/env node
-
 import { fileURLToPath } from 'url'
 import { Command } from 'commander'
 import fs from 'fs'
diff --git a/src/metrics/scripts/docsaudit.ts b/src/metrics/scripts/docsaudit.ts
@@ -1,5 +1,3 @@
-#!/usr/bin/env node
-
 import fs from 'fs'
 import path from 'path'
 import { fileURLToPath } from 'url'
diff --git a/src/metrics/scripts/docstat.ts b/src/metrics/scripts/docstat.ts
@@ -1,5 +1,3 @@
-#!/usr/bin/env node
-
 import fs from 'fs'
 import path from 'path'
 import { Command } from 'commander'

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-#!/usr/bin/env node`
`2`		`-`
`3`	`1`	`import { fileURLToPath } from 'url'`
`4`	`2`	`import { Command } from 'commander'`
`5`	`3`	`import fs from 'fs'`