turn AUTOTITLE to actual titles (#33902)

Peter Bengtsson · web-flow · commit ce97d5d01ebf · 2023-01-25T14:58:59.000Z
diff --git a/lib/find-page.js b/lib/find-page.js
@@ -1,20 +1,20 @@
 import { getLanguageCode } from './patterns.js'
 import getRedirect from './get-redirect.js'
 
-export default function findPage(href, pageMap, redirects) {
+export default function findPage(href, pages, redirects) {
   // remove any fragments
   href = href.replace(/#.*$/, '')
 
-  const redirectsContext = { redirects, pages: pageMap }
+  const redirectsContext = { redirects, pages }
 
   // find the page
-  const page = pageMap[href] || pageMap[getRedirect(href, redirectsContext)]
+  const page = pages[href] || pages[getRedirect(href, redirectsContext)]
   if (page) return page
 
   // get the current language
   const currentLang = getLanguageCode.test(href) ? href.match(getLanguageCode)[1] : 'en'
 
   // try to fall back to English if the translated page can't be found
   const englishHref = href.replace(`/${currentLang}/`, '/en/')
-  return pageMap[englishHref] || pageMap[getRedirect(englishHref, redirectsContext)]
+  return pages[englishHref] || pages[getRedirect(englishHref, redirectsContext)]
 }
diff --git a/lib/render-content/create-processor.js b/lib/render-content/create-processor.js
@@ -44,10 +44,7 @@ export default function createProcessor(context) {
     .use(raw)
     .use(wrapInElement, { selector: 'ol > li img', wrapper: 'span.procedural-image-wrapper' })
     .use(rewriteImgSources)
-    .use(rewriteLocalLinks, {
-      languageCode: context.currentLanguage,
-      version: context.currentVersion,
-    })
+    .use(rewriteLocalLinks, context)
     .use(html)
 }
 
@@ -58,9 +55,6 @@ export function createMinimalProcessor(context) {
     .use(remark2rehype, { allowDangerousHtml: true })
     .use(slug)
     .use(raw)
-    .use(rewriteLocalLinks, {
-      languageCode: context.currentLanguage,
-      version: context.currentVersion,
-    })
+    .use(rewriteLocalLinks, context)
     .use(html)
 }
diff --git a/lib/render-content/plugins/rewrite-local-links.js b/lib/render-content/plugins/rewrite-local-links.js
@@ -8,10 +8,14 @@ import nonEnterpriseDefaultVersion from '../../non-enterprise-default-version.js
 import { allVersions } from '../../all-versions.js'
 import removeFPTFromPath from '../../remove-fpt-from-path.js'
 import readJsonFile from '../../read-json-file.js'
+import findPage from '../../find-page.js'
 
 const supportedPlans = new Set(Object.values(allVersions).map((v) => v.plan))
 const externalRedirects = readJsonFile('./lib/redirects/external-sites.json')
 
+// Meaning it can be 'AUTOTITLE ' or ' AUTOTITLE' or 'AUTOTITLE'
+const AUTOTITLE = /^\s*AUTOTITLE\s*$/
+
 // Matches any <a> tags with an href that starts with `/`
 const matcher = (node) =>
   node.type === 'element' &&
@@ -22,20 +26,34 @@ const matcher = (node) =>
 
 // Content authors write links like `/some/article/path`, but they need to be
 // rewritten on the fly to match the current language and page version
-export default function rewriteLocalLinks({ languageCode, version }) {
+export default function rewriteLocalLinks(context) {
+  const { currentLanguage, currentVersion } = context
   // There's no languageCode or version passed, so nothing to do
-  if (!languageCode || !version) return
+  if (!currentLanguage || !currentVersion) return
 
   return (tree) => {
     visit(tree, matcher, (node) => {
-      const newHref = getNewHref(node, languageCode, version)
+      const newHref = getNewHref(node, currentLanguage, currentVersion)
       if (newHref) {
         node.properties.href = newHref
       }
+      for (const child of node.children) {
+        if (child.value && AUTOTITLE.test(child.value)) {
+          child.value = getNewTitle(node.properties.href, context)
+        }
+      }
     })
   }
 }
 
+function getNewTitle(href, context) {
+  const page = findPage(href, context.pages, context.redirects)
+  if (!page) {
+    throw new Error(`Unable to find Page by href '${href}'`)
+  }
+  return page.title
+}
+
 function getNewHref(node, languageCode, version) {
   const { href } = node.properties
   // Exceptions to link rewriting
diff --git a/lib/rewrite-local-links.js b/lib/rewrite-local-links.js
diff --git a/middleware/context.js b/middleware/context.js
@@ -8,6 +8,7 @@ import warmServer from '../lib/warm-server.js'
 import searchVersions from '../lib/search/versions.js'
 import nonEnterpriseDefaultVersion from '../lib/non-enterprise-default-version.js'
 import { getDataByLanguage, getUIDataMerged } from '../lib/get-data.js'
+
 const activeProducts = Object.values(productMap).filter(
   (product) => !product.wip && !product.hidden
 )
@@ -90,5 +91,6 @@ export default async function contextualize(req, res, next) {
       return context.enPage
     }
   }
+
   return next()
 }

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ import warmServer from '../lib/warm-server.js'`
`8`	`8`	`import searchVersions from '../lib/search/versions.js'`
`9`	`9`	`import nonEnterpriseDefaultVersion from '../lib/non-enterprise-default-version.js'`
`10`	`10`	`import { getDataByLanguage, getUIDataMerged } from '../lib/get-data.js'`
	`11`	`+`
`11`	`12`	`const activeProducts = Object.values(productMap).filter(`
`12`	`13`	`(product) => !product.wip && !product.hidden`
`13`	`14`	`)`
`@@ -90,5 +91,6 @@ export default async function contextualize(req, res, next) {`
`90`	`91`	`return context.enPage`
`91`	`92`	`}`
`92`	`93`	`}`
	`94`	`+`
`93`	`95`	`return next()`
`94`	`96`	`}`