404 if apiVersion is unrecognized (#33850)

Peter Bengtsson · web-flow · commit d27720c72916 · 2023-01-10T00:58:20.000Z
diff --git a/pages/[versionId]/rest/overview/endpoints-available-for-github-apps.tsx b/pages/[versionId]/rest/overview/endpoints-available-for-github-apps.tsx
@@ -94,6 +94,14 @@ export const getServerSideProps: GetServerSideProps<Props> = async (context) =>
   const automatedPageContext = getAutomatedPageContextFromRequest(req)
   const enabledForApps = await getEnabledForApps(currentVersion, apiVersion)
 
+  // If getEnabledForApps came back as undefined, it means that nothing
+  // could be found for that `apiVersion`
+  if (!enabledForApps) {
+    return {
+      notFound: true,
+    }
+  }
+
   return {
     props: {
       mainContext,
diff --git a/tests/rendering/rest.js b/tests/rendering/rest.js
@@ -1,7 +1,7 @@
 import { jest, test } from '@jest/globals'
 import { slug } from 'github-slugger'
 
-import { getDOM } from '../helpers/e2etest.js'
+import { get, getDOM } from '../helpers/e2etest.js'
 import getRest, { getEnabledForApps, categoriesWithoutSubcategories } from '../../lib/rest/index.js'
 import { isApiVersioned, allVersions } from '../../lib/all-versions.js'
 import { getDiffOpenAPIContentRest } from '../../script/rest/test-open-api-schema.js'
@@ -61,6 +61,15 @@ describe('REST references docs', () => {
     }
   })
 
+  test('404 if unrecognized apiVersion', async () => {
+    const res = await get(
+      `/en/rest/overview/endpoints-available-for-github-apps?${new URLSearchParams({
+        apiVersion: 'junk',
+      })}`
+    )
+    expect(res.statusCode).toBe(404)
+  })
+
   test('test the latest version of the OpenAPI schema categories/subcategories to see if it matches the content/rest directory', async () => {
     const differences = await getDiffOpenAPIContentRest()
     const errorMessage = formatErrors(differences)
