From df7f4b14119ea9960db5ed30d1b7bbfec7e58fa2 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 16 Oct 2023 03:08:41 +0000 Subject: [PATCH 1/7] Update rubocop requirement from = 1.56.4 to = 1.57.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.56.4...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 10 +++++----- erblint-github.gemspec | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 989e808..20dcc64 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -52,7 +52,7 @@ GEM mini_portile2 (~> 2.8.2) racc (~> 1.4) parallel (1.23.0) - parser (3.2.2.3) + parser (3.2.2.4) ast (~> 2.4.1) racc racc (1.7.1) @@ -66,14 +66,14 @@ GEM nokogiri (~> 1.14) rainbow (3.1.1) rake (13.0.6) - regexp_parser (2.8.1) + regexp_parser (2.8.2) rexml (3.2.6) - rubocop (1.56.4) + rubocop (1.57.1) base64 (~> 0.1.1) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) - parser (>= 3.2.2.3) + parser (>= 3.2.2.4) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) @@ -109,7 +109,7 @@ DEPENDENCIES minitest (~> 5.20.0) mocha (~> 2.1.0) rake (~> 13.0.6) - rubocop (= 1.56.4) + rubocop (= 1.57.1) rubocop-github (~> 0.20.0) BUNDLED WITH diff --git a/erblint-github.gemspec b/erblint-github.gemspec index 20fee10..cd85251 100644 --- a/erblint-github.gemspec +++ b/erblint-github.gemspec @@ -21,7 +21,7 @@ Gem::Specification.new do |s| s.add_development_dependency "mocha", "~> 2.1.0" s.add_development_dependency "rake", "~> 13.0.6" - s.add_development_dependency "rubocop", "= 1.56.4" + s.add_development_dependency "rubocop", "= 1.57.1" s.add_development_dependency "rubocop-github", "~> 0.20.0" s.metadata["rubygems_mfa_required"] = "true" From dc991bc29424a946cb7598ae93efaaeb59f488f3 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 16 Oct 2023 03:57:13 +0000 Subject: [PATCH 2/7] Bump github/accessibility-alt-text-bot from 1.3.0 to 1.4.0 Bumps [github/accessibility-alt-text-bot](https://github.com/github/accessibility-alt-text-bot) from 1.3.0 to 1.4.0. - [Release notes](https://github.com/github/accessibility-alt-text-bot/releases) - [Commits](https://github.com/github/accessibility-alt-text-bot/compare/v1.3.0...v1.4.0) --- updated-dependencies: - dependency-name: github/accessibility-alt-text-bot dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- .github/workflows/accessibility-alt-text-bot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/accessibility-alt-text-bot.yml b/.github/workflows/accessibility-alt-text-bot.yml index 192edb8..0eac9eb 100644 --- a/.github/workflows/accessibility-alt-text-bot.yml +++ b/.github/workflows/accessibility-alt-text-bot.yml @@ -23,4 +23,4 @@ jobs: if: ${{ github.event.issue || github.event.pull_request || github.event.discussion }} steps: - name: Get action 'github/accessibility-alt-text-bot' - uses: github/accessibility-alt-text-bot@v1.3.0 + uses: github/accessibility-alt-text-bot@v1.4.0 From 7fe1fd1b874a4c10fbe4982041f75f4d536a0746 Mon Sep 17 00:00:00 2001 From: Kate Higa <16447748+khiga8@users.noreply.github.com> Date: Thu, 19 Oct 2023 14:22:08 -0400 Subject: [PATCH 3/7] Add failing test case --- .../no_visually_hidden_interactive_elements_test.rb | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/linters/accessibility/no_visually_hidden_interactive_elements_test.rb b/test/linters/accessibility/no_visually_hidden_interactive_elements_test.rb index 0a5e7e0..5088e9d 100644 --- a/test/linters/accessibility/no_visually_hidden_interactive_elements_test.rb +++ b/test/linters/accessibility/no_visually_hidden_interactive_elements_test.rb @@ -38,12 +38,13 @@ def test_does_not_warn_if_element_is_interactive_and_shown_on_focus assert_empty @linter.offenses end - def test_warn_if_element_is_interactive_in_a_visually_hidden_parent - @file = "
" + def test_does_not_warn_on_unexpected_elements + @file = <<~ERB + + + ERB @linter.run(processed_source) - assert_equal(1, @linter.offenses.count) - error_messages = @linter.offenses.map(&:message).sort - assert_match(/Avoid visually hidding interactive elements. Visually hiding interactive elements can be confusing to sighted keyboard users as it appears their focus has been lost when they navigate to the hidden element/, error_messages.last) + assert_empty @linter.offenses end end From dec5d161ab5ab653069d9449ed8e8be400cfa94b Mon Sep 17 00:00:00 2001 From: Kate Higa <16447748+khiga8@users.noreply.github.com> Date: Thu, 19 Oct 2023 14:22:46 -0400 Subject: [PATCH 4/7] simplify logic for now --- .../no_visually_hidden_interactive_elements.rb | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/erblint-github/linters/github/accessibility/no_visually_hidden_interactive_elements.rb b/lib/erblint-github/linters/github/accessibility/no_visually_hidden_interactive_elements.rb index d431763..3890c7d 100644 --- a/lib/erblint-github/linters/github/accessibility/no_visually_hidden_interactive_elements.rb +++ b/lib/erblint-github/linters/github/accessibility/no_visually_hidden_interactive_elements.rb @@ -14,14 +14,10 @@ class NoVisuallyHiddenInteractiveElements < Linter MESSAGE = "Avoid visually hidding interactive elements. Visually hiding interactive elements can be confusing to sighted keyboard users as it appears their focus has been lost when they navigate to the hidden element" def run(processed_source) - visually_hidden = false - tags(processed_source).each do |tag| next if tag.closing? classes = possible_attribute_values(tag, "class") - visually_hidden = true if classes.include?("sr-only") - next unless classes.include?("sr-only") || visually_hidden - if INTERACTIVE_ELEMENTS.include?(tag.name) + if classes.include?("sr-only") && INTERACTIVE_ELEMENTS.include?(tag.name) generate_offense(self.class, processed_source, tag) end end From 409bd83649d6e47943a23c12d9049e714249ccad Mon Sep 17 00:00:00 2001 From: Kate Higa <16447748+khiga8@users.noreply.github.com> Date: Thu, 19 Oct 2023 14:23:21 -0400 Subject: [PATCH 5/7] Update README --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index eb4b51d..ef9e6d8 100644 --- a/README.md +++ b/README.md @@ -41,6 +41,7 @@ inherit_gem: - [GitHub::Accessibility::NoAriaLabelMisuse](./docs/rules/accessibility/no-aria-label-misuse.md) - [GitHub::Accessibility::NoPositiveTabIndex](./docs/rules/accessibility/no-positive-tab-index.md) - [GitHub::Accessibility::NoRedundantImageAlt](./docs/rules/accessibility/no-redundant-image-alt.md) +- - [GitHub::Accessibility::NoVisuallyHiddenInteractiveElements](./docs/rules/accessibility/no-visually-hidden-interactive-elements.md) - [GitHub::Accessibility::NoTitleAttribute](./docs/rules/accessibility/no-title-attribute.md) - [GitHub::Accessibility::SvgHasAccessibleText](./docs/rules/accessibility/svg-has-accessible-text.md) From 946261f201fe32b2025d4ccfd882505646de4caa Mon Sep 17 00:00:00 2001 From: Kate Higa <16447748+khiga8@users.noreply.github.com> Date: Thu, 19 Oct 2023 14:26:29 -0400 Subject: [PATCH 6/7] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ef9e6d8..785d11e 100644 --- a/README.md +++ b/README.md @@ -41,7 +41,7 @@ inherit_gem: - [GitHub::Accessibility::NoAriaLabelMisuse](./docs/rules/accessibility/no-aria-label-misuse.md) - [GitHub::Accessibility::NoPositiveTabIndex](./docs/rules/accessibility/no-positive-tab-index.md) - [GitHub::Accessibility::NoRedundantImageAlt](./docs/rules/accessibility/no-redundant-image-alt.md) -- - [GitHub::Accessibility::NoVisuallyHiddenInteractiveElements](./docs/rules/accessibility/no-visually-hidden-interactive-elements.md) +- [GitHub::Accessibility::NoVisuallyHiddenInteractiveElements](./docs/rules/accessibility/no-visually-hidden-interactive-elements.md) - [GitHub::Accessibility::NoTitleAttribute](./docs/rules/accessibility/no-title-attribute.md) - [GitHub::Accessibility::SvgHasAccessibleText](./docs/rules/accessibility/svg-has-accessible-text.md) From 7022f3dcacc20ff066b7aeccbb307ac3c7e38520 Mon Sep 17 00:00:00 2001 From: Kate Higa <16447748+khiga8@users.noreply.github.com> Date: Thu, 19 Oct 2023 14:37:58 -0400 Subject: [PATCH 7/7] Bump version to 0.5.1 --- Gemfile.lock | 2 +- erblint-github.gemspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 20dcc64..2d4929d 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - erblint-github (0.5.0) + erblint-github (0.5.1) GEM remote: https://rubygems.org/ diff --git a/erblint-github.gemspec b/erblint-github.gemspec index cd85251..ee3116f 100644 --- a/erblint-github.gemspec +++ b/erblint-github.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = "erblint-github" - s.version = "0.5.0" + s.version = "0.5.1" s.summary = "erblint GitHub" s.description = "Template style checking for GitHub Ruby repositories" s.homepage = "https://github.com/github/erblint-github"