Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify no-visually-hidden-interactive-elements and fix bug #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Simplify no-visually-hidden-interactive-elements and fix bug #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fe1fd1
Add failing test case
khiga8 Oct 19, 2023
dec5d16
simplify logic for now
khiga8 Oct 19, 2023
409bd83
Update README
khiga8 Oct 19, 2023
946261f
Update README.md
khiga8 Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ inherit_gem:
- [GitHub::Accessibility::NoAriaLabelMisuse](./docs/rules/accessibility/no-aria-label-misuse.md)
- [GitHub::Accessibility::NoPositiveTabIndex](./docs/rules/accessibility/no-positive-tab-index.md)
- [GitHub::Accessibility::NoRedundantImageAlt](./docs/rules/accessibility/no-redundant-image-alt.md)
- [GitHub::Accessibility::NoVisuallyHiddenInteractiveElements](./docs/rules/accessibility/no-visually-hidden-interactive-elements.md)
- [GitHub::Accessibility::NoTitleAttribute](./docs/rules/accessibility/no-title-attribute.md)
- [GitHub::Accessibility::SvgHasAccessibleText](./docs/rules/accessibility/svg-has-accessible-text.md)

Expand Down
6 changes: 1 addition & 5 deletions lib/erblint-github/linters/github/accessibility/no_visually_hidden_interactive_elements.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,10 @@ class NoVisuallyHiddenInteractiveElements < Linter
MESSAGE = "Avoid visually hidding interactive elements. Visually hiding interactive elements can be confusing to sighted keyboard users as it appears their focus has been lost when they navigate to the hidden element"

def run(processed_source)
visually_hidden = false

tags(processed_source).each do |tag|
next if tag.closing?
classes = possible_attribute_values(tag, "class")
visually_hidden = true if classes.include?("sr-only")
next unless classes.include?("sr-only") || visually_hidden
if INTERACTIVE_ELEMENTS.include?(tag.name)
if classes.include?("sr-only") && INTERACTIVE_ELEMENTS.include?(tag.name)
generate_offense(self.class, processed_source, tag)
end
end
Expand Down
11 changes: 6 additions & 5 deletions test/linters/accessibility/no_visually_hidden_interactive_elements_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,13 @@ def test_does_not_warn_if_element_is_interactive_and_shown_on_focus
assert_empty @linter.offenses
end

def test_warn_if_element_is_interactive_in_a_visually_hidden_parent
@file = "<div class='sr-only'><button>Submit</button></div>"
def test_does_not_warn_on_unexpected_elements
@file = <<~ERB
<span class="sr-only"></span>
<button></button>
ERB
@linter.run(processed_source)

assert_equal(1, @linter.offenses.count)
error_messages = @linter.offenses.map(&:message).sort
assert_match(/Avoid visually hidding interactive elements. Visually hiding interactive elements can be confusing to sighted keyboard users as it appears their focus has been lost when they navigate to the hidden element/, error_messages.last)
assert_empty @linter.offenses
end
end