Start migrating rules away from counter system #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khiga8
commented
Mar 28, 2023
| @@ -55,7 +55,7 @@ linters: | |||
|
|
|||
| ## Rules | |||
|
|
|||
| - [GitHub::Accessibility::AvoidBothDisabledAndAriaDisabledCounter](./docs/rules/accessibility/avoid-both-disabled-and-aria-disabled-counter.md) | |||
| - [GitHub::Accessibility::AvoidBothDisabledAndAriaDisabledCounter](./docs/rules/accessibility/avoid-both-disabled-and-aria-disabled.md) | |||
There was a problem hiding this comment.
I will remove Counter from names in the README right before we cut release, for alignment with current version.
|
@jonrohan what do you think of this counter deprecation approach? could it work for PVC too? update: chatted in person and on board! |
|
👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.
|
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #56
This PR starts prepping for deprecation of the counter system which we've used as a way to get around lack of support for inline disables. This is no longer necessary with the latest ERB version which now offers inline disable support.
This PR renames
AvoidBothDisabledAndAriaDisabledCounterto beAvoidBothDisabledAndAriaDisabled, deprecating the counter from the name.The to-be-deprecated counter system will continue to work if it's configured explicitly, so existing counter comments shouldn't break. Basically if ERBLint config is:
The existing counter comments shouldn't break. We will default to counter system off. We can keep them enabled and turn them off as we migrate each rule.
This PR adds a doc which we will be surfaced during the new release which instructs how to migrate away from counters.
Preview migration doc 🔍 . I am hoping we can also include a script to ease this migration for our release.
If this approach seems fine, I plan to follow-up with every other rule to prep for migration internally.