Suggest adding native disable instead of counter #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.
|
khiga8
commented
Apr 3, 2023
| @@ -8,24 +8,6 @@ module Linters | |||
| module CustomHelpers | |||
| INTERACTIVE_ELEMENTS = %w[button summary input select textarea a].freeze | |||
|
|
|||
| def rule_disabled?(processed_source) | |||
kendallgassner
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the counter config is enabled, if there is no existing counter comment, let's suggest using
erblint:disableand link to the docs to add inline disable natively, rather than suggesting adding a counter comment which is facing deprecation, now that we got inline disable support natively intoerblint.This PR additionally cleans up an unused method.