Thanks to visit codestin.com
Credit goes to github.com

Skip to content

New rule that flags downcased aria-label #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2023
Merged

New rule that flags downcased aria-label #63

merged 4 commits into from
Apr 11, 2023

Conversation

khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Apr 6, 2023 •
edited
Loading

This PR introduces a new rule that flags downcased aria-label.

This is the ERBLint equivalent of the ESLint custom rule we introduced, a11y-aria-label-is-well-formatted a few weeks ago.

@khiga8 khiga8 marked this pull request as ready for review April 6, 2023 14:16
@khiga8 khiga8 requested a review from a team as a code owner April 6, 2023 14:16
@khiga8 khiga8 requested a review from accessibility-bot April 6, 2023 14:16
@accessibility-bot
Copy link

👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

JoyceZhu
JoyceZhu reviewed Apr 6, 2023
View reviewed changes
JoyceZhu
JoyceZhu reviewed Apr 6, 2023
View reviewed changes
@khiga8 khiga8 requested a review from JoyceZhu April 6, 2023 23:39
JoyceZhu
JoyceZhu approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@JoyceZhu JoyceZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review -- this got lost in the FR deluge.

@khiga8 khiga8 merged commit a14e7c3 into main Apr 11, 2023
@khiga8 khiga8 deleted the kh-aria-label-is-well-formatted branch April 11, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoyceZhu JoyceZhu JoyceZhu approved these changes

@accessibility-bot accessibility-bot Awaiting requested review from accessibility-bot accessibility-bot is a code owner automatically assigned from github/accessibility-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khiga8 @accessibility-bot @JoyceZhu